[No QA] Add odometer distance expense docs to help site#86366
[No QA] Add odometer distance expense docs to help site#86366
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://eac5030d.helpdot.pages.dev ⚡️ Updated articles: |
|
Hi @VictoriaExpensify @stephanieelliott and maybe @trjExpensify. We're about to remove the feature for the Odometer feature. Could you please review and merge when you have a moment, thank you. |
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md
Outdated
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR adds odometer distance expense documentation to the existing Distance Expenses help page. The changes are well-structured: metadata is properly updated, the new procedural section follows the established pattern of the article, and the FAQ entries address practical user questions. However, there are several governance compliance issues in the proposed changes that should be addressed before merging. Scores Summary
Key FindingsIssues that must be addressed:
Positive aspects:
RecommendationsPriority (must fix):
Suggestions (nice to have):
Files Reviewed
Review based on governance rules defined in docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1cfbfbefd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| ## Can I add two odometer images to a distance expense? | ||
|
|
||
| When you add two odometer images to a distance expense, they will be merged into a single image for easy viewing. Click on the image preview to view the original uncropped images. You'll be able to replace or remove the combined image if you need to make a correction. |
There was a problem hiding this comment.
Remove claim that stitched odometer image is replaceable
The FAQ says users can replace or remove the combined odometer image, but stitched odometer receipts explicitly disable replacement in src/pages/media/AttachmentModalScreen/routes/TransactionReceiptModalContent.tsx via isStitchedOdometerReceipt and shouldShowReplaceReceiptButton, and the Replace button is hidden for that case. This creates a user-facing mismatch where the documented correction path is not available in the receipt preview UI.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@Julesssss is this true? I can 't find the ad hoc build to test, but it seems like the ND feature was designed so the image could be replaced, right?
There was a problem hiding this comment.
They can update the cropped photo by replacing individual start/end photos. But that is prior to expense creation... I will simplify this FAQ
|
Reviewing! |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@Julesssss I committed a couple bot suggestions, just one open question for you in the file re: whether the image can be deleted or not. If the help site language is correct, feel free to dismiss that comment. Other than, that this is ready to publish! We'll just want to time this so that it's published when the feature hits prod (not before, as AZ will start telling people about it) -- feel free to merge it yourself at that time. |
|
Thanks @stephanieelliott! I clarified that FAQ with a simplified answer. Great, I'll hold this until the beta is removed. |
|
Pretty sure this goes live once it hits main. So I'll merge this next week shortly after we remove the beta. |
|
Feature is live! |
|
🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.54-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.54-7 🚀
|
Add Odometer expense feature details:
Tracking Issue: https://github.com/Expensify/Expensify/issues/571644
Holding until feature is about to go live.