Show deactivated Expensify Cards in workspace card management#86420
Show deactivated Expensify Cards in workspace card management#86420
Conversation
Cards with a $0 limit are set to STATE_DEACTIVATED by the backend, which causes them to be filtered out of the workspace Expensify Card list. This prevents admins from raising the limit to reactivate the card in NewDot. Add an includeDeactivated parameter to filterAllInactiveCards and create a new filterInactiveCardsIncludingDeactivated selector for workspace admin card management pages only. Non-admin consumers keep the existing behavior. Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@MelvinBot fix conflicts |
Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>
|
Conflicts resolved and merged |
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Explanation of Change
When an Expensify Card has a $0 limit, the backend sets its state to
STATE_DEACTIVATED(5). The frontend'sfilterAllInactiveCardsfunction inCardUtils.tsincludesSTATE_DEACTIVATEDin itsclosedStatesset, which causes these cards to be filtered out of the workspace Expensify Card list. This prevents admins from seeing or managing these cards in NewDot.This PR adds an
includeDeactivatedparameter tofilterAllInactiveCardsand creates a newfilterInactiveCardsIncludingDeactivatedselector used exclusively by workspace card management pages. All other consumers (wallet, overview, workspaces list, company cards, error checking) retain the existing filtering behavior.Changes:
CardUtils.ts: AddedincludeDeactivatedparam tofilterAllInactiveCards, newfilterInactiveCardsIncludingDeactivatedselector, and updatedgetAllCardsForWorkspaceto accept the flagWorkspaceExpensifyCardPage,WorkspaceEditCardLimitPage,WorkspaceEditCardNamePage,WorkspaceEditCardLimitTypePage): Switched to the new selectorWorkspaceExpensifyCardDetailsPage: PassesincludeDeactivated=truetogetAllCardsForWorkspaceFixed Issues
$ #82466
PROPOSAL: #82466 (comment)
Tests
STATE_DEACTIVATED)Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari