Remove old native biometry#86440
Conversation
|
|
a6cf4b9 to
f8a828c
Compare
88b0fab to
061a70f
Compare
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
src/components/MultifactorAuthentication/biometrics/useNativeBiometrics.ts
Outdated
Show resolved
Hide resolved
src/components/MultifactorAuthentication/biometrics/useNativeBiometrics.ts
Outdated
Show resolved
Hide resolved
src/components/MultifactorAuthentication/biometrics/useNativeBiometrics.ts
Outdated
Show resolved
Hide resolved
src/components/MultifactorAuthentication/biometrics/useNativeBiometrics.ts
Outdated
Show resolved
Hide resolved
dariusz-biela
left a comment
There was a problem hiding this comment.
Apart from those comments, I think everything is fine; I don't see any regression.
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ShridharGoel @chuckdries @rafecolton One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@hoangzinh Will you be picking this? |
|
No new product considerations here, so unsubscribing. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppbiometrics.work.after.old.lib.removed.android.mp4iOS: HybridAppbiometrics.work.after.old.lib.removed.ios.mp4 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.55-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR removes internal native biometrics code ( |
Explanation of Change
A follow up to #86310 - this pull request removes the old native biometrics, which used
nobleandexpo-secure-storeFixed Issues
$ #81912
PROPOSAL:
Tests
Testbutton next to itGot itGot itand verify that the registration succeeded - 'Biometrics (registered)' is displayed and aRevokebutton is shown.Offline tests
N/A
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-08.at.12.20.47.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-04-08.at.13.13.35.mov
iOS: mWeb Safari
MacOS: Chrome / Safari