fix: default share sheet option to Submit#86507
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d030a02dc1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <OnyxTabNavigator | ||
| id={CONST.TAB.SHARE.NAVIGATOR_ID} | ||
| tabBar={TabSelector} | ||
| defaultSelectedTab={CONST.TAB.SHARE.SUBMIT} |
There was a problem hiding this comment.
Bypass persisted tab state when defaulting to Submit
defaultSelectedTab={CONST.TAB.SHARE.SUBMIT} does not actually make Submit the default once a tab choice is already saved, because OnyxTabNavigator prefers the persisted selectedTab over defaultSelectedTab (validInitialTab in src/libs/Navigation/OnyxTabNavigator.tsx). In practice, users who previously landed on/used SHARE (for example after sharing a non-scannable file where only Share exists) will keep reopening on Share, so this change does not reliably deliver the intended default behavior.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@daledah, this is correct, which means this will not be testable on an already existing account. Could you add this to test steps please?
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
bump here @getusha |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-06.at.09.51.34.movAndroid: mWeb ChromeN/A iOS: HybridAppScreen.Recording.2026-04-06.at.09.47.10.moviOS: mWeb SafariN/A MacOS: Chrome / SafariN/A |
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.54-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. Why: This PR changes the default tab on the mobile Share sheet from "remember last used" to always defaulting to "Submit." The existing help site articles under |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.54-7 🚀
|
Explanation of Change
Fixed Issues
$ #81503
PROPOSAL: #81503 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
and.mov
Android: mWeb Chrome
N/A
iOS: Native
Screen.Recording.2026-02-10.at.02.26.24.mov
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
N/A