Skip to content

[No QA] docs: add Spend over time section to Home Overview#86597

Merged
Kel-Expensify merged 4 commits intomainfrom
claude-addSpendOverTimeToHomeOverviewDoc
Apr 1, 2026
Merged

[No QA] docs: add Spend over time section to Home Overview#86597
Kel-Expensify merged 4 commits intomainfrom
claude-addSpendOverTimeToHomeOverviewDoc

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

  • Adds documentation for the new Spend over time widget on the Home page, introduced in Create SpendOverTime widget for the Home page #85417
  • Updates the "What Home shows" list to include the new section
  • Adds a dedicated "How the Spend over time section works on Home" section describing the line chart widget, eligibility (workspace admins, auditors, and approvers on paid workspaces), and the View button
  • Adds a FAQ entry explaining why the section may not be visible

Test plan

  • Verify the article renders correctly on the HelpDot staging site
  • Confirm all headings are task-based per HELP_AUTHORING_GUIDELINES.md
  • Confirm UI element names match the product (e.g., Spend over time, View)
  • Confirm the section order matches the actual Home page layout

Add documentation for the new Spend over time widget on the Home page,
which displays a line chart of workspace spending trends for eligible
users (workspace admins, auditors, and approvers on paid workspaces).

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a "Spend over time" section to the Expensify Home Overview article. The changes are well-scoped, consisting of YAML metadata updates, a new bullet in the summary list, a new descriptive section, and a new FAQ entry. The new content follows the existing article's established patterns and is clear and concise. One metadata bug fix (period to comma in keywords) is a welcome correction.

Scores Summary

  • Readability: 9/10 - The new content is clear, scannable, and well-structured. The three-paragraph section body follows a logical progression: what it is, who can see it and what they can do, and when it will not appear. The FAQ answer is direct and self-contained.
  • AI Readiness: 9/10 - Keywords and internalScope are both updated to include the new feature. The added keywords ("Spend over time, spending chart, insights") reflect realistic search terms. The heading and FAQ entry both use the full feature name, aiding semantic retrieval. The period-to-comma fix in the existing keywords array is a valuable correction.
  • Style Compliance: 8/10 - UI element formatting is correct: Spend over time and View are properly bolded. The heading follows the established "How the [section] works on Home" pattern. One issue: "Click View" uses web-only interaction language without accounting for mobile users. Per HELPSITE_NAMING_CONVENTIONS.md cross-platform rules, if the interaction exists on both platforms, mobile phrasing ("Tap") should also be provided.

Key Findings

  • The metadata keyword fix (changing assigned cards. Expensify Card limit to assigned cards, Expensify Card limit) corrects a syntax error in the original file where a period was used instead of a comma delimiter. This is a good catch.
  • The new section and FAQ entry are placed in the correct logical order relative to existing sections, maintaining the article's structure.
  • The heading "How the Spend over time section works on Home" is consistent with the pattern used by all other section headings in this article (e.g., "How the For you section works on Home", "How the Discover section works on Home").
  • The phrase "Click View" on line 76 of the diff only addresses web users. Per the cross-platform clarity rules in HELPSITE_NAMING_CONVENTIONS.md, if the interaction is available on mobile, a "Tap" variant should be provided. If the chart feature is web-only, this should be stated explicitly (e.g., "This feature is not available on mobile.").
  • Role names ("workspace admins, auditors, and approvers") are used in lowercase. If the product UI capitalizes these roles, they should match exactly per the Core UI Referencing Rules.

Recommendations

  1. Address cross-platform phrasing for the View action. Replace "Click View" with platform-specific instructions, or clarify if this action is web-only. For example: "Click or tap View to open the full Spend over time chart on the Search page." Alternatively, if web and mobile navigation differ: provide separate Web/Mobile lines.
  2. Verify role capitalization against the product UI. Confirm whether the UI displays "Workspace Admins" or "workspace admins" and match accordingly.
  3. Both items above are minor. The content is otherwise ready and well-aligned with governance standards.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md -- Metadata keywords and internalScope updated; new "Spend over time" bullet added to summary list; new "How the Spend over time section works on Home" section added; new FAQ entry "Why don't I see the Spend over time section?" added. All changes are consistent with existing article patterns and governance requirements.

Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance files.

@github-actions github-actions bot changed the title docs: add Spend over time section to Home Overview [No QA] docs: add Spend over time section to Home Overview Mar 28, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Mar 28, 2026

A preview of your ExpensifyHelp changes have been deployed to https://3f1c8d67.helpdot.pages.dev ⚡️

Updated articles:

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott stephanieelliott requested a review from a team March 31, 2026 18:54
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 31, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @Kel-Expensify

@melvin-bot melvin-bot bot requested review from Kel-Expensify and removed request for a team March 31, 2026 18:54
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Mar 31, 2026

@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Capitalized the first letters of auditors and approvers to match the way Workspace Admin was capitalized, listing the user types.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

The only failing check is CLA / CLA with the error:

Committers of Pull Request number 86597 have to sign the CLA 📝

This is not a code issue — it's because MelvinBot is not included in the CLA bot allowlist. The current allowlist is: snyk-bot, OSBotify, os-botify[bot], imgbot[bot].

To fix this, MelvinBot needs to be added to the CLA allowlist in the cla.yml workflow (in the Expensify/GitHub-Actions repo), or alternatively, a human committer who has already signed the CLA can re-author the commits.

The build check is still pending (not failing), and all other checks are passing.

@Kel-Expensify
Copy link
Copy Markdown
Contributor

@stephanieelliott I submitted a request to change the user titles to capital letters. The way it reads, I would think that the bolded words in text below would link to something but they don't. Also, no screenshot of what is being described.

Click View to open the full Spend over time chart on the Search page.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

The only failing check is CLA / CLA. The CLA bot shows:

  • MelvinBot — signed
  • stephanieelliott — signed
  • Kel-Expensifynot signed

Kel-Expensify has a commit on this PR (kel@expensify.com) and needs to sign the CLA by posting the following as a comment on this PR:

I have read the CLA Document and I hereby sign the CLA

After that, comment recheck to retrigger the CLA bot.

The build check is still pending (not failing), and all other checks are passing. This is not a code issue — no code fix needed.

@Kel-Expensify
Copy link
Copy Markdown
Contributor

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Apr 1, 2026
@stephanieelliott
Copy link
Copy Markdown
Contributor

stephanieelliott commented Apr 1, 2026

Thanks @Kel-Expensify! Appreciate the thorough review!

There are 2 screenshots in the article, they may have been easy to miss since images don't render until the article is published.

Re: the bolding, by all default all UI elements are bolded in the help articles. I don't think they present like links once rendered (you can see the live version of this page here), maybe a broader discussion to have later if we want to move away from that.

Accepted your changes, please approve this PR if all looks good! To do that, go to Files changed (top of this page) > Submit Review > Approve > Submit review

@stephanieelliott
Copy link
Copy Markdown
Contributor

@MelvinBot why did you ask kel-expensify to sign the CLA? She is an internal employee at Expensify, the CLA is not required.

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Good question! To clarify — I didn't directly ask Kel-Expensify to sign the CLA. I was reporting the status of the CLA / CLA check, which was failing. The CLA Assistant Lite bot is what actually enforces the CLA requirement.

The CLA workflow (cla.yml) uses an allowlist to skip the CLA check for certain accounts, but that list currently only contains bots: snyk-bot, OSBotify, os-botify[bot], imgbot[bot]. It doesn't have any mechanism to exempt Expensify employees — it treats all committers the same way and requires anyone not on the allowlist to sign.

So when Kel-Expensify pushed a commit and hadn't signed the CLA on this repo, the CLA bot flagged it as a failure. I reported what the check was showing and how to unblock it.

If internal employees shouldn't need to sign the CLA, the fix would be in the CLA workflow configuration — for example, adding an org membership check or expanding the allowlist. That change would live in Expensify/GitHub-Actions.

@Kel-Expensify Kel-Expensify merged commit 15b0dd8 into main Apr 1, 2026
15 of 16 checks passed
@Kel-Expensify Kel-Expensify deleted the claude-addSpendOverTimeToHomeOverviewDoc branch April 1, 2026 17:27
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 2, 2026

🚀 Deployed to staging by https://github.com/Kel-Expensify in version: 9.3.52-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 7, 2026

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants