[No QA] docs: add Spend over time section to Home Overview#86597
[No QA] docs: add Spend over time section to Home Overview#86597Kel-Expensify merged 4 commits intomainfrom
Conversation
Add documentation for the new Spend over time widget on the Home page, which displays a line chart of workspace spending trends for eligible users (workspace admins, auditors, and approvers on paid workspaces). Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md
Outdated
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR adds a "Spend over time" section to the Expensify Home Overview article. The changes are well-scoped, consisting of YAML metadata updates, a new bullet in the summary list, a new descriptive section, and a new FAQ entry. The new content follows the existing article's established patterns and is clear and concise. One metadata bug fix (period to comma in keywords) is a welcome correction. Scores Summary
Key Findings
Recommendations
Files Reviewed
Review based on docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md governance files. |
|
A preview of your ExpensifyHelp changes have been deployed to https://3f1c8d67.helpdot.pages.dev ⚡️ Updated articles: |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Capitalized the first letters of auditors and approvers to match the way Workspace Admin was capitalized, listing the user types.
|
All contributors have signed the CLA ✍️ ✅ |
|
The only failing check is CLA / CLA with the error:
This is not a code issue — it's because To fix this, The |
|
@stephanieelliott I submitted a request to change the user titles to capital letters. The way it reads, I would think that the bolded words in text below would link to something but they don't. Also, no screenshot of what is being described. Click View to open the full Spend over time chart on the Search page. |
|
The only failing check is CLA / CLA. The CLA bot shows:
After that, comment recheck to retrigger the CLA bot. The |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks @Kel-Expensify! Appreciate the thorough review! There are 2 screenshots in the article, they may have been easy to miss since images don't render until the article is published. Re: the bolding, by all default all UI elements are bolded in the help articles. I don't think they present like links once rendered (you can see the live version of this page here), maybe a broader discussion to have later if we want to move away from that. Accepted your changes, please approve this PR if all looks good! To do that, go to |
|
@MelvinBot why did you ask |
|
Good question! To clarify — I didn't directly ask The CLA workflow (cla.yml) uses an So when If internal employees shouldn't need to sign the CLA, the fix would be in the CLA workflow configuration — for example, adding an org membership check or expanding the allowlist. That change would live in |
|
🚀 Deployed to staging by https://github.com/Kel-Expensify in version: 9.3.52-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀
|
Summary
Test plan