Skip to content

[No QA] Update business bank account help articles#86599

Open
MelvinBot wants to merge 12 commits intomainfrom
claude-helpSiteBusinessBankAccount
Open

[No QA] Update business bank account help articles#86599
MelvinBot wants to merge 12 commits intomainfrom
claude-helpSiteBusinessBankAccount

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Summary

Updates all 5 business bank account help articles to comply with HelpDot authoring guidelines (HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, TEMPLATE.md) and adds new content for Phases 3-5 of the business bank account conversion project.

Articles updated:

  • Connect a Business Bank Account — Replaced "Step N:" headings with task-based headings, added Wallet entry point (Phase 4), linking existing accounts (Phase 3), and Wallet display changes (Phase 5)
  • Validate a Business Bank Account — Restructured to single title, task-based headings, added Wallet navigation
  • Unlock a Business Bank Account — Restructured headings, flattened ACH info sections, added Wallet/Workflows visibility for locked badges
  • Share a Business Bank Account — Fixed three dots menu formatting, added relative cross-links, task-based headings
  • Unshare a Business Bank Account — Fixed three dots menu formatting, task-based headings, consistent navigation

Key formatting changes across all articles:

  • Exactly one # heading (article title) + optional # FAQ
  • All ## headings start with a question word (How, What, Where, Who, Why, When)
  • Added internalScope to all metadata blocks
  • Three dots menu: the three dots **(⋮)** (per naming conventions)
  • Cross-links use relative paths
  • Screenshot placeholders use HTML comments
  • Consistent web and mobile navigation instructions

Related to: https://github.com/Expensify/Expensify/issues/530547

Co-authored-by: stephanieelliott stephanie@expensify.com

Test plan

  • Verify articles render correctly on the help site (Jekyll build)
  • Confirm all relative cross-links resolve correctly
  • Review existing screenshots still display properly
  • Verify metadata (title, description, keywords, internalScope) is correct for each article
  • Sense-check content accuracy against current UI

…ompliance

Revises all 5 business bank account help articles to follow HelpDot authoring
guidelines: task-based headings, single # title structure, internalScope metadata,
correct three dots formatting, relative cross-links, and HTML comment screenshot
placeholders. Adds new content for Wallet entry point, linking existing accounts,
and bank account status badges.

Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@github-actions github-actions bot changed the title Update business bank account help articles [No QA] Update business bank account help articles Mar 28, 2026
stephanieelliott and others added 2 commits April 8, 2026 10:12
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

Fixed the failing spellcheck: two typos in Connect-a-Business-Bank-Account.mdscreendhotsscreenshots (line 39) and accounaccount (line 65).

@MelvinBot
Copy link
Copy Markdown
Contributor Author

Fixed the failing spellcheck: corrected two typos in Connect-a-Business-Bank-Account.mdWorkdpaceWorkspace (line 10) and phyicalphysical (line 20).

@stephanieelliott stephanieelliott marked this pull request as ready for review April 9, 2026 07:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

HelpDot Documentation Review

Overall Assessment

This PR rewrites five business bank account articles (Connect, Share, Unshare, Unlock, Validate) to align with current HelpDot governance standards. The changes are substantial and move these articles significantly closer to compliance: legacy <div id="new-expensify"> wrappers are removed, YAML frontmatter now includes internalScope, headings are converted to task-based ## format, navigation instructions follow the unified pattern, and three-dots menu references are corrected. The overall quality is high with a few items to address.

Scores Summary

  • Readability: 9/10 - Steps are clear, sequential, and action-oriented. Sentences are concise and scannable. Minor formatting inconsistency in one file (missing period on step 6 in Unshare).
  • AI Readiness: 9/10 - All five articles now have internalScope, task-based headings with feature names, and proper heading hierarchy (single # title plus ## sections plus # FAQ). Every article includes at least one "How to" heading. Keywords are realistic search phrases.
  • Style Compliance: 8/10 - Three-dots menu references are correctly formatted in Share and Unshare articles. Navigation instructions use the unified pattern consistently. A few items noted below need attention.

Key Findings

Positive aspects:

  • Excellent addition of internalScope to all five articles, with clear audience, covered workflows, and explicit exclusions.
  • Consistent use of the unified navigation pattern: "In the navigation tabs (on the left on web, on the bottom on mobile)".
  • Good cross-linking with descriptive anchor text (e.g., "learn how to share a business bank account") placed outside of numbered steps.
  • FAQ headings are properly task-based or question-based throughout.
  • Removal of legacy <div> wrappers and cleanup of excessive bold formatting improves readability.

Items to address:

  1. Connect article -- heading without action verb or question word: The heading ## How business bank accounts appear in Wallet is borderline. Per governance, all ## headings must start with an action verb or question word. "How" is acceptable as a question word, so this passes, but consider whether "Where to find business bank accounts in Wallet" would better match a user's search intent.

  2. Unshare article -- broken horizontal rule: Line -- (should be ---) will not render as a horizontal rule in Markdown. This appears between the "What happens after" section and the screenshots.

  3. Unshare article -- missing period on step 6: Step 6 reads 6. Click **Confirm** without a trailing period, while all other steps end with periods. Minor but inconsistent.

  4. Connect article -- external full URL: The link to census.gov/naics uses a full external URL (https://www.census.gov/naics/...). Per cross-linking standards, full URLs should be avoided for internal links -- but this is an external government site, so it is acceptable. Just flagging for awareness.

  5. Connect article -- link inside numbered step: In the "How to add a new US business bank account in Wallet" section, step 6 says "Complete the identity verification, company details, and Beneficial Owner steps described below." This is fine. However, in the "What to expect after submitting" section, item 3 includes an inline link: "Learn how to validate a business bank account." Per governance, links should not be placed inside numbered step instructions. Consider moving this link after the numbered list.

  6. Validate article -- heading style: ## When can a business bank account be validated does not start with a standard action verb or question word from the governance list. "When" is listed as acceptable, so this passes technically, but the content under it is more procedural context than a direct answer to "when." Consider rephrasing to something like ## What happens before you can validate a business bank account.

Recommendations

  1. Fix the broken -- horizontal rule in the Unshare article (change to ---).
  2. Move the inline link in the Connect article's numbered "What to expect" list to after the list, per cross-linking standards.
  3. Add trailing period to step 6 in the Unshare article for consistency.
  4. Review whether the "When can a business bank account be validated" heading in the Validate article could be rephrased for stronger task-based clarity.

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md - Major rewrite. Well-structured with proper metadata, task-based headings, and clear steps. Minor link placement issue in numbered list.
  • docs/articles/new-expensify/wallet-and-payments/Share-a-Business-Bank-Account.md - Good rewrite. Proper three-dots formatting, streamlined FAQ, correct cross-links.
  • docs/articles/new-expensify/wallet-and-payments/Unlock-a-Business-Bank-Account.md - Solid rewrite. Clear unlock workflow, proper FAQ addition, correct heading structure.
  • docs/articles/new-expensify/wallet-and-payments/Unshare-a-Business-Bank-Account.md - Good rewrite. Broken horizontal rule (-- instead of ---) needs fix. Missing period on one step.
  • docs/articles/new-expensify/wallet-and-payments/Validate-a-Business-Bank-Account.md - Clean rewrite. Good troubleshooting section moved inline. One heading could be stronger.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
Copy link
Copy Markdown
Contributor

@MelvinBot why did you leave comments, instead of in-line suggestions which can be committed?

@MelvinBot
Copy link
Copy Markdown
Contributor Author

The review comments with formatting feedback (missing commas, broken horizontal rules, etc.) were posted by github-actions[bot] — a separate automated workflow that runs on HelpDot PRs — not by me directly. I don't control the output format of that workflow, so I can't make it use committable inline suggestions.

That said, I can fix all of those issues right now if you'd like — just reply with @MelvinBot fix the review comments and I'll push commits addressing them.

@stephanieelliott
Copy link
Copy Markdown
Contributor

Addressed all bot comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants