[No QA] perf: remove redundant reportNameValuePairs collection subscription from LHN by BartekObudzinski · Pull Request #86644 · Expensify/App

BartekObudzinski · 2026-03-30T11:00:14Z

Explanation of Change

LHNOptionsList subscribed to the entire COLLECTION.REPORT_NAME_VALUE_PAIRS via useOnyx, then passed scoped entries as props to each OptionRowLHNData. However, OptionRowLHNData already has its own per-item useOnyx subscription for the same data (reportNameValuePairsEntry). The collection subscription was redundant.

The collection sub appeared in both renderItem deps (16 deps) and extraData (9 deps). Any NVP change for any report (e.g., archiving) invalidated the entire FlashList, causing all visible rows to re-render.

This PR removes the collection subscription and the prop fallback, relying solely on the per-item subscription that was already in place.

Profiling Results (React DevTools Profiler, archiving a report):

Total duration: -14%
LHNOptionsList: -19%
OptionRowLHNData: -19%
OptionRowLHN: -13%

Reassure benchmark: zero regression on existing SidebarLinks tests.

Fixed Issues

$ #86649
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…rom LHN

…ction-sub-from-lhn # Conflicts: # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/LHNOptionsList/OptionRowLHNData.tsx # src/components/LHNOptionsList/types.ts

melvin-bot · 2026-03-31T07:29:10Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-31T07:33:40Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/LHNOptionsList/LHNOptionsList.tsx	`85.41% <100.00%> (+2.96%)`	⬆️
src/components/LHNOptionsList/OptionRowLHNData.tsx	`83.58% <83.33%> (-5.31%)`	⬇️
... and 19 files with indirect coverage changes

hungvu193 · 2026-03-31T10:11:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-31.at.15.52.25.mov

hungvu193 · 2026-03-31T10:46:15Z

Found this issue while testing, the last text message isn't updated with this report. I'll double-check with staging to verify:

JS00001

Code lgtm

BartekObudzinski · 2026-03-31T12:25:30Z

@hungvu193 Could you provide more details or steps to reproduce, becasue I couldn't reproduce that

hungvu193 · 2026-03-31T12:26:58Z

@hungvu193 Could you provide more details or steps to reproduce, becasue I couldn't reproduce that

Yeah let me veirfy from end first, I'll keep you posted.

hungvu193 · 2026-03-31T15:10:57Z

just double check and it's not related, that's workspace name 😅 . We're good to go here.

github-actions · 2026-03-31T15:15:28Z

🚧 @JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-31T15:19:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86644.

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed

Web 🕸️
❌ FAILED ❌
The QR code can't be generated, because the Web build failed

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-31T20:05:38Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.3.51-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-03-31T20:07:02Z

No help site changes are required.

I reviewed the changes in this PR — it's a pure internal performance optimization that removes a redundant reportNameValuePairs collection subscription from the LHN components (LHNOptionsList.tsx, OptionRowLHNData.tsx, types.ts).

This PR does not alter any:

User-facing features or behavior
UI labels, button names, or settings
Workflows or navigation flows
Feature additions, removals, or renames

Since the help site docs under App/docs/articles document user-facing functionality, and this PR only refactors internal React component data subscriptions for performance, no documentation updates are needed.

OSBotify · 2026-04-02T19:56:42Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.51-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

perf: remove redundant reportNameValuePairs collection subscription f…

36a5abf

…rom LHN

melvin-bot bot assigned BartekObudzinski Mar 30, 2026

JS00001 mentioned this pull request Mar 30, 2026

[Due for Payment 2026-04-10] Remove redundant reportNameValuePairs collection subscription from LHN #86649

Open

Merge remote-tracking branch 'origin/main' into perf/remove-nvp-colle…

e79cbe8

…ction-sub-from-lhn # Conflicts: # src/components/LHNOptionsList/LHNOptionsList.tsx # src/components/LHNOptionsList/OptionRowLHNData.tsx # src/components/LHNOptionsList/types.ts

BartekObudzinski marked this pull request as ready for review March 31, 2026 07:29

BartekObudzinski requested review from a team as code owners March 31, 2026 07:29

melvin-bot bot requested review from hungvu193 and trjExpensify and removed request for a team March 31, 2026 07:29

melvin-bot bot removed the request for review from a team March 31, 2026 07:29

BartekObudzinski mentioned this pull request Mar 31, 2026

[Metrics] Improve ManualNavigateToInboxTab #77175

Open

JS00001 approved these changes Mar 31, 2026

View reviewed changes

hungvu193 approved these changes Mar 31, 2026

View reviewed changes

melvin-bot bot requested a review from JS00001 March 31, 2026 15:11

JS00001 approved these changes Mar 31, 2026

View reviewed changes

JS00001 merged commit f508fd7 into Expensify:main Mar 31, 2026
37 checks passed

This was referenced Mar 31, 2026

Remove onClick from non-interactive Pressables to fix TalkBack a11y #86731

Merged

Block currency changes when workspace has partially setup bank account #86075

Merged

OSBotify mentioned this pull request Mar 31, 2026

Deploy Checklist: New Expensify 2026-03-31 #86774

Closed

OSBotify mentioned this pull request Mar 31, 2026

Chat - Chat is scrolling up after editing a message #86813

Closed

7 tasks

nabi-ebrahimi mentioned this pull request Apr 1, 2026

[No QA][Perf] Scope VISIBLE_REPORT_ACTIONS subscription to per-row level in LHNOptionsList #86417

Closed

52 tasks

OSBotify mentioned this pull request Apr 1, 2026

Report - {report:startdate} appears briefly when creating a scan expense in empty report #86839

Closed

7 tasks

Conversation

BartekObudzinski commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 31, 2026

Uh oh!

codecov bot commented Mar 31, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hungvu193 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski commented Mar 31, 2026

Uh oh!

hungvu193 commented Mar 31, 2026

Uh oh!

hungvu193 commented Mar 31, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

github-actions bot commented Mar 31, 2026

Uh oh!

OSBotify commented Mar 31, 2026

Uh oh!

MelvinBot commented Mar 31, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BartekObudzinski commented Mar 30, 2026 •

edited

Loading

codecov bot commented Mar 31, 2026 •

edited by github-actions bot

Loading

hungvu193 commented Mar 31, 2026 •

edited

Loading

hungvu193 commented Mar 31, 2026 •

edited

Loading