fix - concierge task is not auto-completed after completing Test drive via Reports tab by apeyada · Pull Request #86717 · Expensify/App

apeyada · 2026-03-31T08:17:15Z

Explanation of Change

Call openReport for concierge chat manually when open test drive demo page but viewTourTaskReport doesn't exist.

Fixed Issues

$ #76714
PROPOSAL: #76714 (comment)

Tests

Prerequisite: Invite a brand new account to a workspace

Open the app
Sign-in with the invited user
Go to the Reports tab > Expenses.
Tap the "Take a test drive" button
Finish Test Drive
Tap Get Started
Navigate to the Concierge chat
Verify that the Test Drive task in the Concierge chat should be completed

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

…e via Reports tab

melvin-bot · 2026-03-31T08:36:12Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-31T08:50:40Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/TestDrive/TestDriveDemo.tsx	`0.00% <0.00%> (ø)`
... and 23 files with indirect coverage changes

aimane-chnaif · 2026-04-01T07:41:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MelvinBot · 2026-04-01T07:48:52Z

🔍 PR Review

Summary: The approach is sound — when viewTourTaskReport is undefined (the task hasn't been loaded into Onyx yet), calling openReport on the concierge chat triggers the server to populate the task, after which completeTestDriveTask can run. All CI checks pass and the reviewer checklist is complete.

One concern — potential for repeated openReport calls:

The useEffect calls openReport every time any dependency changes while viewTourTaskReport is still undefined. Notably, openReport itself optimistically merges {isInviteOnboardingComplete: true} into NVP_INTRO_SELECTED (Report/index.ts:1222-1229), which changes the introSelected reference — a dependency of this very effect — causing it to re-fire.

The likely sequence is:

Mount: conciergeReportID is undefined → openReport no-ops (early return at !reportID guard)
conciergeReportID arrives from server → effect re-fires → openReport makes the API call + optimistic merge to NVP_INTRO_SELECTED
introSelected changes from the merge → effect re-fires → viewTourTaskReport still undefined → openReport called again (though RequestConflictUtils will replace the queued request)
Server responds with viewTour ID → introSelected changes again → effect re-fires → viewTourTaskReport now exists → completeTestDriveTask runs

So openReport gets called ~2-3 times before things stabilize. The conflict resolver mitigates duplicate API traffic, but a useRef guard would make the intent clearer and prevent unnecessary calls:

const hasCalledOpenReportRef = useRef(false);

useEffect(() => {
    if (hasSeenTour) {
        return;
    }
    if (!viewTourTaskReport) {
        if (conciergeReportID && !hasCalledOpenReportRef.current) {
            hasCalledOpenReportRef.current = true;
            openReport({reportID: conciergeReportID, introSelected});
        }
        return;
    }
    // ... rest unchanged

This ensures openReport fires exactly once (only when conciergeReportID is available), and avoids coupling correctness to Onyx change propagation timing.

This is a non-blocking suggestion — the current code works correctly due to the conflict resolver and the eventual stabilization of dependencies, but the ref guard would be a nice hardening.

Cat fact: A group of cats is called a "clowder," but a group of kittens is called a "kindle."

aimane-chnaif · 2026-04-01T07:51:55Z

Good suggestion. @apeyada let's apply!

chatgpt-codex-connector · 2026-04-01T07:54:23Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-04-01T16:15:56Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-01T16:21:25Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86717.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2f80a9d-08e403c-cc771e996458bf1a4f5f897b556a9613d24c6e6b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2f80a9d-08e403c-1157a8c435dc03f65751a6799bea0801f6bc9ff6/index.html

Web 🕸️
https://86717.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-02T20:21:23Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-02T20:22:48Z

No help site changes are needed.

This PR is a code-level bug fix in TestDriveDemo.tsx that ensures the concierge task auto-completes after finishing the Test Drive via the Reports tab. It adds a fallback openReport call when viewTourTaskReport doesn't exist — it doesn't change any user-facing feature names, UI labels, settings, or workflows.

There are no existing help site articles referencing "test drive" under docs/articles/, and this fix doesn't alter any documented behavior.

OSBotify · 2026-04-07T01:12:22Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.52-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix - concierge task is not auto-completed after completing Test driv…

d9fd2d8

…e via Reports tab

melvin-bot bot assigned apeyada Mar 31, 2026

apeyada marked this pull request as ready for review March 31, 2026 08:36

apeyada requested review from a team as code owners March 31, 2026 08:36

melvin-bot bot requested review from aimane-chnaif and heyjennahay March 31, 2026 08:36

melvin-bot bot removed request for a team March 31, 2026 08:36

Merge branch 'Expensify:main' into fix-76714

ef6c745

Merge branch 'Expensify:main' into fix-76714

05a9c27

address review

2ba5fef

aimane-chnaif approved these changes Apr 1, 2026

View reviewed changes

melvin-bot bot requested a review from luacmartins April 1, 2026 08:04

luacmartins approved these changes Apr 1, 2026

View reviewed changes

luacmartins merged commit 2f80a9d into Expensify:main Apr 1, 2026
32 checks passed

github-actions bot mentioned this pull request Apr 1, 2026

Investigate workflow job failing on main: typecheck / typecheck #86900

Closed

MelvinBot mentioned this pull request Apr 1, 2026

Update CTA and workspace chat copy for track-intent users #86460

Merged

52 tasks

OSBotify mentioned this pull request Apr 2, 2026

Deploy Checklist: New Expensify 2026-04-02 #86989

Closed

melvin-bot bot mentioned this pull request Apr 7, 2026

[Due for payment 2026-04-14] [$500] iOS - The concierge task is not auto-completed after completing Test drive via Reports tab #76714

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix - concierge task is not auto-completed after completing Test drive via Reports tab#86717

fix - concierge task is not auto-completed after completing Test drive via Reports tab#86717
luacmartins merged 4 commits intoExpensify:mainfrom
apeyada:fix-76714

apeyada commented Mar 31, 2026 •

edited

Loading

Uh oh!

melvin-bot bot commented Mar 31, 2026

Uh oh!

codecov bot commented Mar 31, 2026 •

edited by github-actions bot

Loading

Uh oh!

aimane-chnaif commented Apr 1, 2026 •

edited

Loading

Uh oh!

MelvinBot commented Apr 1, 2026

Uh oh!

aimane-chnaif commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 1, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

MelvinBot commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

apeyada commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 31, 2026

Uh oh!

codecov bot commented Mar 31, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aimane-chnaif commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 1, 2026

🔍 PR Review

Uh oh!

aimane-chnaif commented Apr 1, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 1, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

MelvinBot commented Apr 2, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

apeyada commented Mar 31, 2026 •

edited

Loading

codecov bot commented Mar 31, 2026 •

edited by github-actions bot

Loading

aimane-chnaif commented Apr 1, 2026 •

edited

Loading