decompose ReportScreen 6d: extract navigate-away handler#86721
decompose ReportScreen 6d: extract navigate-away handler#86721rlinoz merged 2 commits intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
f02033f to
92bb48f
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-03.at.23.48.50.movAndroid: mWeb ChromeScreen.Recording.2026-04-03.at.23.43.33.moviOS: HybridAppScreen.Recording.2026-04-03.at.23.45.04.moviOS: mWeb SafariScreen.Recording.2026-04-03.at.23.43.00.movMacOS: Chrome / SafariScreen.Recording.2026-04-03.at.23.39.54.mov |
This step looks incorrect in some cases. This is an example Screen.Recording.2026-04-03.at.23.41.28.mov |
|
hm does the same happen on |
|
Yes |
|
The change is working fine, but I think this step is incorrect |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a pure internal refactor — it extracts navigate-away logic from |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.53-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.53-7 🚀
|
@rlinoz
Explanation of Change
Extracts
ReportNavigateAwayHandlerfromReportScreenas part of the ongoing ReportScreen decomposition (issue #84895). This is PR 6d in the series.The new
ReportNavigateAwayHandleris a renderless component (returnsnull) that owns two pieces of navigate-away logic previously inline inReportScreen:useReportWasDeletedhook to detect when a previously-accessible report gets deleted, and navigates away.Fixed Issues
$ #84895
Tests
Offline tests
N/A — pure refactor, navigate-away logic is unchanged.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari