fix: personal information RHP remains loading after reloading the page by thelullabyy · Pull Request #86929 · Expensify/App

thelullabyy · 2026-04-02T00:48:04Z

Explanation of Change

Fixed Issues

$ #85488
PROPOSAL: #85488 (comment)

Tests

Go to Workspace -> Workflows -> Add bank account
Click on "Log into your bank account"
Click on the "Confirm" button
Complete the add bank account flow until the "Personal Information" step.
Go offline
Complete personal information steps and reach the confirmation page
Go online and refresh the page
Personal Information confirm RHP should be displayed after reloading the page.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to Workspace -> Workflows -> Add bank account
Click on "Log into your bank account"
Click on the "Confirm" button
Complete the add bank account flow until the "Personal Information" step.
Go offline
Complete personal information steps and reach the confirmation page
Go online and refresh the page
Personal Information confirm RHP should be displayed after reloading the page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Updatingg... (I'm having build issue with android)

Android: mWeb Chrome

android_web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

website_.mov

codecov · 2026-04-02T00:58:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/DelegateAccessHandler.tsx	`94.11% <100.00%> (ø)`
.../ReimbursementAccount/ReimbursementAccountPage.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

melvin-bot · 2026-04-02T01:16:32Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2026-04-02T08:50:00Z

src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

+        if ((isPreviousPolicy && !!reimbursementAccount) || isLoadingOnyxValue(reimbursementAccountMetadata)) {
            return;


@thelullabyy Are we going to fix the OpenApp in DelegateAccessHandler as you described in your proposal as well?

Yes, I've added that change

hungvu193 · 2026-04-03T10:40:22Z

src/DelegateAccessHandler.tsx

@@ -1,4 +1,5 @@
 import {useEffect, useRef} from 'react';
+import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue';


@thelullabyy Please fix this linting

hungvu193 · 2026-04-07T02:13:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-08.at.15.24.52.mov

Android: mWeb Chrome

Screen.Recording.2026-04-08.at.15.27.33.mov

iOS: HybridApp

Screen.Recording.2026-04-08.at.15.15.19.mov

iOS: mWeb Safari

Screen.Recording.2026-04-08.at.15.12.05.mov

MacOS: Chrome / Safari

Chrome.mov

hungvu193 · 2026-04-07T02:24:17Z

@thelullabyy Are we going to fix this case as well?

Precondition: Already reached steps 3

Continue setup.
At step 3, turn on and then turn off the offline mode.
Reload the page.

Screen.Recording.2026-04-07.at.09.22.04.mov

thelullabyy · 2026-04-08T07:02:09Z

I'm checking it

thelullabyy · 2026-04-08T07:39:00Z

@hungvu193 I tested this case in our PR, and I don't see OpenApp API being called.

hungvu193 · 2026-04-08T07:58:58Z

@hungvu193 I tested this case in our PR, and I don't see OpenApp API being called.

Hmm yeah, I also couldn't reproduce it now

hungvu193

LGTM

hungvu193 · 2026-04-08T15:18:28Z

All yours @pecanoro

github-actions · 2026-04-08T16:57:59Z

🚧 @pecanoro has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-08T17:02:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86929.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ccb83a9-77157b8-a18fb4530859148d3f4a352c390730bfdb066fc8/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ccb83a9-77157b8-fe3692982a467cc54ce53c7356f9c27773b0bdb6/index.html

Web 🕸️
https://86929.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-08T17:08:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-09T00:57:33Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.55-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-09T01:01:51Z

No help site changes are required for this PR.

The changes are purely technical bug fixes to Onyx loading state checks in DelegateAccessHandler.tsx and ReimbursementAccountPage.tsx. They fix a race condition where the "Personal Information" RHP remained in a loading state after page reload — no user-facing features, labels, navigation, or workflows were changed.

fix: personal information RHP remains loading after reloading the page

5cc44a0

melvin-bot bot assigned thelullabyy Apr 2, 2026

thelullabyy marked this pull request as ready for review April 2, 2026 01:16

thelullabyy requested review from a team as code owners April 2, 2026 01:16

melvin-bot bot requested review from hungvu193 and removed request for a team April 2, 2026 01:16

melvin-bot bot requested review from heyjennahay and removed request for a team April 2, 2026 01:16

hungvu193 reviewed Apr 2, 2026

View reviewed changes

thelullabyy added 2 commits April 3, 2026 00:08

Merge branch 'main' of https://github.com/Expensify/App into feat/85488

140b21c

fix DelegateAccessHandler

62aeae9

hungvu193 reviewed Apr 3, 2026

View reviewed changes

thelullabyy added 2 commits April 7, 2026 00:09

fix: conflicts

e520454

fix: lint

c8b50f6

pecanoro self-requested a review April 6, 2026 21:08

merge main

60bc142

hungvu193 approved these changes Apr 8, 2026

View reviewed changes

pecanoro approved these changes Apr 8, 2026

View reviewed changes

pecanoro merged commit ccb83a9 into Expensify:main Apr 8, 2026
32 checks passed

OSBotify mentioned this pull request Apr 9, 2026

Deploy Checklist: New Expensify 2026-04-09 #87435

Open

63 tasks

		if ((isPreviousPolicy && !!reimbursementAccount) \|\| isLoadingOnyxValue(reimbursementAccountMetadata)) {
		return;

		@@ -1,4 +1,5 @@
		import {useEffect, useRef} from 'react';
		import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue';

Conversation

thelullabyy commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Apr 2, 2026

Uh oh!

hungvu193 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

thelullabyy Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Apr 7, 2026

Uh oh!

thelullabyy commented Apr 8, 2026

Uh oh!

thelullabyy commented Apr 8, 2026

Uh oh!

hungvu193 commented Apr 8, 2026

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Apr 8, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

thelullabyy commented Apr 2, 2026 •

edited

Loading

codecov bot commented Apr 2, 2026 •

edited by github-actions bot

Loading

hungvu193 commented Apr 7, 2026 •

edited

Loading