Deleted transactions on search V2

[jnowakow]

@luacmartins

Explanation of Change

This PR adds support deleted transactions on search.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/608639
PROPOSAL: N/A

Tests

1. Go to Reports > Expenses
2. Select Deleted status fileter
3. Verify that deleted transactions are shown
4. Select at least one
5. Select "Undelete" option from dropdown menu.
6. Verify that reports are moved to selfDM

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Go to Reports > Expenses
2. Select Deleted status fileter
3. Verify that deleted transactions are shown
4. Select at least one
5. Select "Undelete" option from dropdown menu.
6. Verify that reports are moved to selfDM

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	93.65% <ø> (ø)
...hList/ListItem/ActionCell/actionTranslationsMap.ts	100.00% <ø> (ø)
...ts/Search/SearchList/ListItem/ActionCell/index.tsx	68.42% <100.00%> (ø)
...h/SearchList/ListItem/ExpenseReportListItemRow.tsx	0.00% <ø> (ø)
...earch/SearchList/ListItem/ReportListItemHeader.tsx	97.14% <ø> (ø)
...mponents/Search/SearchList/ListItem/StatusCell.tsx	60.00% <100.00%> (ø)
...h/SearchList/ListItem/TransactionGroupListItem.tsx	70.83% <ø> (ø)
...SearchList/ListItem/UserInfoAndActionButtonRow.tsx	100.00% <ø> (ø)
src/components/Search/SearchList/index.tsx	43.96% <100.00%> (+0.48%)	⬆️
...ponents/TransactionItemRow/DataCells/TotalCell.tsx	80.00% <ø> (ø)
... and 15 more
... and 8 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 040f009777

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Block row navigation for deleted grouped transactions

This only disables the arrow callback for deleted child rows, but in narrow/grouped layouts the outer row press handler still calls handleOnPress(transaction) and opens the report/thread. As a result, tapping a deleted transaction row (outside the action button) still navigates instead of enforcing undelete-only behavior, which contradicts the new deleted transaction flow and can send users into an invalid detail path.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Keep button role on clickable transaction rows

The role assignment is inverted: non-deleted rows remain clickable but are now rendered with role='none', while deleted rows get a button role even when onPress is disabled. This regresses accessibility semantics for the main transaction list (screen readers/keyboard users lose button semantics on active rows and may get misleading semantics on inactive ones).

Useful? React with 👍 / 👎.

[luacmartins]

@jnowakow how's this one coming along? Which bugs are left to be fixed?

[jnowakow]

@luacmartins I'm currently working on this one:

• [Due for payment 2026-04-14] Expense - Undeleted IOU expense shows negative amount #86788

Those two are discussed with Garret and Lucien:

• [Due for payment 2026-04-14] LHN - LHN shows original amount instead of split amount after undeleting expense #86782
• [Due for payment 2026-04-14] Reports - Deleted split expense does not show up when filtered with status:deleted #86835

Those are in the the queue

• [Due for payment 2026-04-14] Expense - Undeleted expense does not load when undeleted and opened offline #86793
• [Due for payment 2026-04-14] Expense - "Unheld the expense" message is shown after undeleting held expense #86799
• [Due for payment 2026-04-14] Expense - Selection mode persists after undeleting all expenses offline #86790

Those fixes for those issues are merged to this branch:

• [Due for payment 2026-04-14] Expense - Tapping on expense row does not deselect or select expense #86780
• [Due for payment 2026-04-14] Reports - Deleted expense with negative amount is not shown negative #86783
• [Due for payment 2026-04-14] Reports - Category column does not align with the table header #86791
• [Due for payment 2026-04-14] Reports - Non functional View button is shown instead of Undelete button #86796
• [Due for payment 2026-04-14] Reports - Merged expense appears when filtering by "Deleted" with the kept amount. #86850

And to this we agreed that it's not a bug:

• [Due for payment 2026-04-14] Reports - Merged expense appears when filtering by "Deleted" with the kept amount. #86850

[luacmartins]

Thanks for the update! Let's keep the momentum on this one!

[jnowakow]

@luacmartins current status of this PR:

Those fixes for those issues are merged to this branch:

• [Due for payment 2026-04-14] Expense - Tapping on expense row does not deselect or select expense #86780
• [Due for payment 2026-04-14] Reports - Deleted expense with negative amount is not shown negative #86783
• [Due for payment 2026-04-14] Reports - Category column does not align with the table header #86791
• [Due for payment 2026-04-14] Reports - Non functional View button is shown instead of Undelete button #86796
• [Due for payment 2026-04-14] Reports - Merged expense appears when filtering by "Deleted" with the kept amount. #86850
• [Due for payment 2026-04-14] Expense - Selection mode persists after undeleting all expenses offline #86790
• [Due for payment 2026-04-14] Expense - Undeleted expense does not load when undeleted and opened offline #86793
• [Due for payment 2026-04-14] LHN - LHN shows original amount instead of split amount after undeleting expense #86782

Issues fixed in Auth:

• [Due for payment 2026-04-14] Expense - "Unheld the expense" message is shown after undeleting held expense #86799 - PR: https://github.com/Expensify/Auth/pull/20961

And to this we agreed that it's not a bug:

• [Due for payment 2026-04-14] Reports - Merged expense appears when filtering by "Deleted" with the kept amount. #86850
• [Due for payment 2026-04-14] Expense - Undeleted IOU expense shows negative amount #86788
• [Due for payment 2026-04-14] Reports - Deleted split expense does not show up when filtered with status:deleted #86835

[jnowakow]

I think that last thing is the case when user deletes all splits at once:

1. Create expense
2. Split expense
3. Select all splits
4. Delete all splits
5. Go to Reports > Expenses.
6. Filter by status: deleted

delete-all-splits-at-once.mov

What is expected behaviour in this situation? cc @lakchote @garrettmknight

[garrettmknight]

I take my earlier comment back. This looks great.