Skip to content

[HOLD for feature release] Expensify Card spend rules to Workspace Rules help article#86994

Open
MelvinBot wants to merge 1 commit intomainfrom
claude-addSpendRulesHelpDocs
Open

[HOLD for feature release] Expensify Card spend rules to Workspace Rules help article#86994
MelvinBot wants to merge 1 commit intomainfrom
claude-addSpendRulesHelpDocs

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Explanation of Change

Documents the new Spend rules section added to the Workspace Rules page in #86572. Updates Workspace-Rules.md to explain the built-in Expensify Card protections that block transactions in restricted merchant categories (adult services, ATMs, gambling, money transfers), and how to view them.

Changes:

  • Added "How Expensify Card spend rules work" section with navigation steps and explanation
  • Updated keywords and internalScope metadata to include spend rules

Fixed Issues

$ #86520

Tests

  1. Build the help site locally or preview the markdown
  2. Verify the new "How Expensify Card spend rules work" section renders correctly
  3. Verify navigation steps are clear and match the UI flow
  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation-only change.

QA Steps

  1. Verify the new section appears in the rendered Workspace Rules help article
  2. Verify the navigation steps match the actual UI in the app
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A — documentation-only change.

Documents the new Spend section that appears on the Rules page when
Expensify Cards are enabled, including the built-in card protection
that blocks adult services, ATMs, gambling, and money transfers.

Co-authored-by: Carlos Martins <luacmartins@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team April 2, 2026 20:24
@MelvinBot MelvinBot mentioned this pull request Apr 2, 2026
62 tasks
@luacmartins luacmartins marked this pull request as ready for review April 6, 2026 16:42
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 6, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @sonialiap

@melvin-bot melvin-bot bot requested review from sonialiap and removed request for a team April 6, 2026 16:45
@melvin-bot
Copy link
Copy Markdown

melvin-bot bot commented Apr 6, 2026

@sonialiap Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

HelpDot Documentation Review

Overall Assessment

This PR adds a new "Spend" section documenting Expensify Card spend rules to the Workspace Rules article. The changes include a new informational section with navigation steps, updated YAML metadata (keywords and internalScope), and a heading-level fix that demotes the existing "How to configure Expense Report rules" from # to ##. The additions are well-structured and largely compliant with governance standards.

Scores Summary

  • Readability: 9/10 - Clear, concise prose. Steps are sequential and easy to follow. The bulleted list of blocked categories is scannable.
  • AI Readiness: 9/10 - Metadata updates are well-aligned with search intent. New keywords ("spend rules", "Expensify Card rules", "card protection", "block transactions") cover realistic search queries. The internalScope update accurately reflects the new coverage. Heading includes the feature name.
  • Style Compliance: 9/10 - Navigation uses the correct unified format per HELPSITE_NAMING_CONVENTIONS.md. UI elements (Workspaces, Rules, Spend, All cards, Got it) are properly bolded. The heading demotion from # to ## on "How to configure Expense Report rules" is a welcome compliance fix.

Key Findings

  • Positive: The ## How Expensify Card spend rules work heading follows the "How [Feature Name] works" pattern explicitly listed as acceptable in TEMPLATE.md. Good use of the feature name for retrieval.
  • Positive: Demoting # How to configure Expense Report rules to ## corrects a heading hierarchy violation, bringing it closer to the one-#-heading rule.
  • Positive: The Note callout clearly communicates the visibility condition for the Spend section, which helps prevent user confusion.
  • Minor: The navigation step says "click Workspaces" -- verify this matches the exact UI label (singular vs. plural). Per HELPSITE_NAMING_CONVENTIONS.md, the tab label must match exactly.
  • Pre-existing issue (not scored): The file still has multiple # headings elsewhere (e.g., # How to configure Expense Rules, # How to configure Category Rules). These are outside the scope of this diff but worth noting for a future cleanup pass.

Recommendations

  1. Verify UI labels: Confirm that All cards, Spend, and Got it match the exact text in the product UI, including capitalization.
  2. Consider a follow-up PR: The remaining # headings in the file should be demoted to ## to fully comply with the single-#-heading rule from HELP_AUTHORING_GUIDELINES.md.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Workspace-Rules.md — New section added for Expensify Card spend rules; metadata updated; one heading hierarchy fix applied. Changes are clean and compliant.

Review based on governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

@stephanieelliott stephanieelliott changed the title Add Expensify Card spend rules to Workspace Rules help article [HOLD for feature release] Expensify Card spend rules to Workspace Rules help article Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants