Pass default tax code in skip-confirmation expense creation paths by wildan-m · Pull Request #87064 · Expensify/App

wildan-m · 2026-04-03T09:30:42Z

Explanation of Change

When creating expenses via quick scan (skip-confirmation) or distance request paths, the tax code and tax amount were not being passed to trackExpense and requestMoney. This caused the default workspace tax code to be missing from the created transaction, resulting in incorrect or empty tax fields when exported using {expense:tax:code}.

This fix computes the default tax code using getDefaultTaxCode and passes both taxCode and taxAmount to the expense creation calls in createTransaction and handleMoneyRequestStepDistanceNavigation.

Fixed Issues

$ #86891
PROPOSAL: #86891 (comment)

Tests

Preconditions:

In Expensify Classic (OD), go to Settings > Workspaces > [Workspace] > Export Formats and create a new export format that includes {expense:tax:code}
In New Expensify (ND), go to Workspaces > [Workspace] > More Features > Organize and enable Taxes
Ensure the workspace has a default tax rate configured under Workspaces > [Workspace] > Taxes
For distance expense testing: go to Workspaces > [Workspace] > Distance rates > Settings and enable Track Tax

Scan expense (confirmation flow - baseline):
5. In ND, go to the workspace chat and create a scan expense (this goes through the confirmation page and sets up the Quick Action for the next step)

Scan expense (Quick Action - skips confirmation):
6. Click the global (+) FAB — at the bottom there should now be a Quick Action "Scan expense" (this appears because step 5 set the last used action)
7. Add a receipt and create (this skips the confirmation page and creates the expense immediately)

Distance expense (Quick Action - skips confirmation):
8. First create a distance expense from the workspace chat (to set up the Quick Action), then use the (+) FAB Quick Action to create another distance expense

Export verification:
9. Go to Reports, select the report containing the above expenses
10. Export using the export format created in step 1
11. Verify {expense:tax:code} is populated for all expenses — including those created via Quick Action (steps 7 and 8), not just the ones from the confirmation flow

Verify that no errors appear in the JS console

Offline tests

The tax code is applied locally before the API call, so offline behavior should be unchanged. The expense will be created with the correct tax code optimistically.

QA Steps

Same as tests above, using a workspace with tax tracking enabled on staging.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Kapture.2026-04-04.at.10.50.58_compressed.mp4

Android: mWeb Chrome

Kapture.2026-04-04.at.10.57.06_compressed.mp4

iOS: Native

Kapture.2026-04-04.at.10.34.45_compressed.mp4

iOS: mWeb Safari

Kapture.2026-04-04.at.10.39.42_compressed.mp4

MacOS: Chrome / Safari

Kapture.2026-04-04.at.10.17.47_compressed.mp4

Quick-scan expense creation paths (createTransaction, distance quick-scan) were not passing taxCode/taxAmount to the downstream action functions (requestMoney, trackExpense, createDistanceRequest). This caused the backend to store an empty taxCode, making the {expense:tax:code} custom export formula produce blank output. Compute the default tax code from the policy (matching the confirmation page logic in IOURequestStepConfirmation.tsx) and pass it through all three affected paths.

…x-code-quick-scan

codecov · 2026-04-03T09:49:55Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/MoneyRequest.ts	`92.17% <100.00%> (+0.31%)`	⬆️
... and 6 files with indirect coverage changes

…x-code-quick-scan

…/requestMoney

melvin-bot · 2026-04-04T04:05:51Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64a8c611b5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/actions/IOU/MoneyRequest.ts

ikevin127 · 2026-04-05T01:14:04Z

@codex review

ikevin127 · 2026-04-05T01:14:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-04-04.at.18.54.44.mov

chatgpt-codex-connector · 2026-04-05T01:24:53Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

ikevin127

🟢 LGTM

JmillsExpensify

LGTM

github-actions · 2026-04-07T07:45:54Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-04-07T07:49:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-07T07:50:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87064.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4b173be-9989e33-a98ffdfe333746a87bc0772e3839ec9c1ea26da1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4b173be-9989e33-51ed0e6adc837b8e64e39c31982ee161ec245899/index.html

Web 🕸️
https://87064.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-08T00:19:30Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.54-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-08T00:21:57Z

No help site changes are required for this PR.

This is an internal bug fix that ensures taxCode and taxAmount are correctly passed to trackExpense and requestMoney in skip-confirmation (quick scan) and distance expense creation paths. No user-facing features, UI labels, settings, or workflows were added or changed — the fix simply corrects existing behavior so tax fields populate as they already should have been.

OSBotify · 2026-04-09T00:32:38Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.3.54-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned wildan-m Apr 3, 2026

wildan-m added 4 commits April 3, 2026 16:30

Merge remote-tracking branch 'upstream/main' into wildan/86891-fix-ta…

5c4fe0b

…x-code-quick-scan

Add unit tests for tax code passthrough in createTransaction

397d2a0

Use concrete empty string for taxCode assertion

9d16dce

Add missing defaultValue to taxRates in test fixtures

02ba753

wildan-m added 2 commits April 4, 2026 09:09

Merge remote-tracking branch 'upstream/main' into wildan/86891-fix-ta…

ca1ca00

…x-code-quick-scan

Fix test references: use TrackExpense instead of IOU for trackExpense…

64a8c61

…/requestMoney

wildan-m marked this pull request as ready for review April 4, 2026 04:05

wildan-m requested review from a team as code owners April 4, 2026 04:05

melvin-bot bot requested review from JmillsExpensify and ikevin127 April 4, 2026 04:05

melvin-bot bot removed request for a team April 4, 2026 04:05

wildan-m mentioned this pull request Apr 4, 2026

[Due for payment 2026-04-16] [$250] Custom export format formula not working {expense:tax:code} #86891

Open

7 tasks

chatgpt-codex-connector bot reviewed Apr 4, 2026

View reviewed changes

src/libs/actions/IOU/MoneyRequest.ts Show resolved Hide resolved

Pass policyParams in GPS-error and no-location-permission paths

0059c47

ikevin127 approved these changes Apr 5, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski April 5, 2026 01:58

JmillsExpensify approved these changes Apr 6, 2026

View reviewed changes

mjasikowski approved these changes Apr 7, 2026

View reviewed changes

mjasikowski merged commit 4b173be into Expensify:main Apr 7, 2026
34 of 35 checks passed

OSBotify mentioned this pull request Apr 7, 2026

Deploy Checklist: New Expensify 2026-04-07 #87294

Closed

97 tasks

Conversation

wildan-m commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Apr 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ikevin127 commented Apr 5, 2026

Uh oh!

ikevin127 commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector bot commented Apr 5, 2026

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

MelvinBot commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wildan-m commented Apr 3, 2026 •

edited

Loading

codecov bot commented Apr 3, 2026 •

edited by github-actions bot

Loading

ikevin127 commented Apr 5, 2026 •

edited

Loading