Add userSelect to outermost Text in TextCommentFragment by MelvinBot · Pull Request #87107 · Expensify/App

MelvinBot · 2026-04-03T16:35:54Z

Explanation of Change

The (edited) label in text-rendered comments was not included in triple-click paragraph selection on web. The outermost Text component in TextCommentFragment lacked a userSelect style, so the browser excluded the (edited) label from selection. This adds userSelect: 'text' (with the same touch-screen/narrow-layout conditional already used by inner components) to the outermost Text wrapper, ensuring the entire comment — including (edited) — is selected on triple-click.

Fixed Issues

$ #86871
PROPOSAL: #86871 (comment)

Tests

Navigate to New Dot on web (Chrome)
Open any chat that contains edited messages
Triple-click on an edited message
Verify the (edited) label is included in the selection
Verify no errors appear in the JS console

Verify that no errors appear in the JS console

Offline tests

N/A — this is a CSS selection behavior change; no network dependency.

QA Steps

Navigate to New Dot on web (Chrome)
Open any chat that contains edited messages
Triple-click on an edited message
Verify the (edited) label is included in the text selection

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — web-only CSS selection change

Android: mWeb Chrome

N/A — web-only CSS selection change

iOS: Native

N/A — web-only CSS selection change

iOS: mWeb Safari

N/A — web-only CSS selection change

MacOS: Chrome / Safari

Apply userSelect: 'text' to the outermost Text component in TextCommentFragment so the (edited) label is included in triple-click paragraph selection on web. Co-authored-by: dmkt9 <dmkt9@users.noreply.github.com>

dmkt9 · 2026-04-04T02:20:11Z

src/pages/inbox/report/comment/TextCommentFragment.tsx

Suggested change

Applied — removed the redundant userSelect style since the outermost Text wrapper already handles it.

dmkt9 · 2026-04-04T02:20:26Z

src/pages/inbox/report/comment/TextCommentFragment.tsx

Suggested change

Applied — same as above, removed the duplicate userSelect from the inner Text as well.

The outermost Text wrapper already applies userSelect, so the inner TextWithEmojiFragment and Text components don't need it duplicated. Co-authored-by: dmkt9 <dmkt9@users.noreply.github.com>

codecov · 2026-04-04T02:32:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...pages/inbox/report/comment/TextCommentFragment.tsx	`74.28% <50.00%> (+3.23%)`	⬆️
... and 23 files with indirect coverage changes

dmkt9 · 2026-04-07T13:32:55Z

@MelvinBot, please mark this PR as ready.

MelvinBot · 2026-04-07T13:34:18Z

PR has been marked as ready for review.

melvin-bot · 2026-04-07T13:34:20Z

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-07T13:35:02Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dmkt9 · 2026-04-07T14:33:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- Windows/Linux: Chrome
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Does not affect:

android.native.mp4

Android: mWeb Chrome

Does not affect:

android.chrome.mp4

iOS: HybridApp

Does not affect:

ios.native.mp4

iOS: mWeb Safari

Does not affect:

ios.safari.mp4

MacOS: Chrome / Safari

Does not affect:

mac.safari.mp4

Windows/Linux: Chrome

chrome.mp4

dmkt9 · 2026-04-07T14:34:12Z

@codex review

dmkt9 · 2026-04-07T14:42:09Z

@MelvinBot, please merge the latest changes from the main branch

chatgpt-codex-connector · 2026-04-07T14:48:39Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…sTripleClickSelect Co-authored-by: dmkt9 <dmkt9@users.noreply.github.com>

MelvinBot · 2026-04-07T14:49:13Z

Merged the latest changes from main into this branch.

melvin-bot · 2026-04-07T14:49:53Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

LGTM

JmillsExpensify · 2026-04-08T11:47:50Z

Looks like I'm the last one unless @AndrewGable also needs to review?

mjasikowski · 2026-04-08T14:10:47Z

I'll merge, let's only have one person to blame if anything goes wrong lol

github-actions · 2026-04-08T14:11:31Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-08T14:16:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87107.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d9b9684-f7288ea-7206c18403abc78ed48865c6725dffdbf2925dd4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d9b9684-f7288ea-0e6f12d28a24d5d7448e7734fc9594c0226a0b54/index.html

Web 🕸️
https://87107.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-08T14:20:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-09T00:58:09Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.55-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-09T01:02:23Z

No help site changes are required for this PR.

This is a CSS-only fix (userSelect: 'text' on the outermost Text wrapper in TextCommentFragment.tsx) that ensures the (edited) label is included in triple-click paragraph selection on web. It doesn't change any user-facing features, workflows, or settings that are documented in App/docs/articles.

Add userSelect to outermost Text in TextCommentFragment

c441dd5

Apply userSelect: 'text' to the outermost Text component in TextCommentFragment so the (edited) label is included in triple-click paragraph selection on web. Co-authored-by: dmkt9 <dmkt9@users.noreply.github.com>

MelvinBot assigned dmkt9 Apr 3, 2026

MelvinBot requested a review from a team April 3, 2026 16:35

MelvinBot mentioned this pull request Apr 3, 2026

[$250] Chat - Edited status is not selected when triple clicking a message #86871

Open

7 tasks

dmkt9 suggested changes Apr 4, 2026

View reviewed changes

Remove redundant userSelect styles from inner components

b30c1fc

The outermost Text wrapper already applies userSelect, so the inner TextWithEmojiFragment and Text components don't need it duplicated. Co-authored-by: dmkt9 <dmkt9@users.noreply.github.com>

MelvinBot marked this pull request as ready for review April 7, 2026 13:34

MelvinBot requested a review from a team as a code owner April 7, 2026 13:34

melvin-bot bot requested review from JmillsExpensify and dmkt9 and removed request for a team April 7, 2026 13:34

melvin-bot bot requested review from a team and AndrewGable and removed request for a team April 7, 2026 13:34

Merge remote-tracking branch 'origin/main' into claude-fixEditedStatu…

fdd63d6

…sTripleClickSelect Co-authored-by: dmkt9 <dmkt9@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner April 7, 2026 14:49

melvin-bot bot requested a review from mjasikowski April 7, 2026 14:49

melvin-bot bot removed the request for review from a team April 7, 2026 14:49

dmkt9 approved these changes Apr 7, 2026

View reviewed changes

mjasikowski approved these changes Apr 8, 2026

View reviewed changes

JmillsExpensify approved these changes Apr 8, 2026

View reviewed changes

mjasikowski merged commit d9b9684 into main Apr 8, 2026
37 checks passed

mjasikowski deleted the claude-fixEditedStatusTripleClickSelect branch April 8, 2026 14:10

OSBotify mentioned this pull request Apr 9, 2026

Deploy Checklist: New Expensify 2026-04-09 #87435

Open

63 tasks

Conversation

MelvinBot commented Apr 3, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

dmkt9 Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

dmkt9 Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 4, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dmkt9 commented Apr 7, 2026

Uh oh!

MelvinBot commented Apr 7, 2026

Uh oh!

melvin-bot bot commented Apr 7, 2026

Uh oh!

melvin-bot bot commented Apr 7, 2026

Uh oh!

dmkt9 commented Apr 7, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

dmkt9 commented Apr 7, 2026

Uh oh!

dmkt9 commented Apr 7, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 7, 2026

Uh oh!

MelvinBot commented Apr 7, 2026

Uh oh!

melvin-bot bot commented Apr 7, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Apr 8, 2026

Uh oh!

mjasikowski commented Apr 8, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Apr 4, 2026 •

edited by github-actions bot

Loading