Open
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index d566be3d..9c82fced 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1692,8 +1692,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Modal-Hintergrund',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1701,8 +1699,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Warte darauf, dass <strong>Sie</strong> Spesen hinzufügen.`;
@@ -1718,8 +1714,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Wartet darauf, dass <strong>Sie</strong> Spesen einreichen.`;
@@ -1741,8 +1735,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Warten darauf, dass <strong>Sie</strong> ein Bankkonto hinzufügen.`;
@@ -1762,8 +1754,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `am ${eta} eines jeden Monats` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Warten darauf, dass <strong>Ihre</strong> Ausgaben automatisch eingereicht werden${formattedETA}.`;
@@ -1779,8 +1769,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Warten auf <strong>Sie</strong>, um die Probleme zu beheben.`;
@@ -1796,8 +1784,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Es wird darauf gewartet, dass <strong>Sie</strong> Spesen genehmigen.`;
@@ -1813,8 +1799,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Warte darauf, dass <strong>Sie</strong> diesen Bericht exportieren.`;
@@ -1830,8 +1814,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Wartet darauf, dass <strong>Sie</strong> Spesen bezahlen.`;
@@ -1847,8 +1829,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Warten darauf, dass <strong>Sie</strong> die Einrichtung eines Geschäftskontos abschließen.`;
@@ -6869,7 +6849,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: 'Öffentlicher Nahverkehr und Fahrgemeinschaften',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: 'Reisebüros',
},
- editRuleTitle: 'Ausgaberegel bearbeiten',
+ editRuleTitle: 'Regel bearbeiten',
deleteRule: 'Regel löschen',
deleteRuleConfirmation: 'Sind Sie sicher, dass Sie diese Regel löschen möchten?',
},
@@ -7371,8 +7351,6 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
updatedDefaultTitle: (newDefaultTitle: string, oldDefaultTitle: string) => `benutzerdefinierte Berichtstitelformel in „${newDefaultTitle}“ geändert (zuvor „${oldDefaultTitle}“)`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `hat die Inhaberschaft von ${policyName} von ${oldOwnerName} (${oldOwnerEmail}) übernommen`,
updatedAutoHarvesting: (enabled: boolean) => `${enabled ? 'aktiviert' : 'deaktiviert'} geplante Einreichung`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index ff5bf500..6907bdde 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1697,8 +1697,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Arrière-plan de la fenêtre modale',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1706,8 +1704,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vous</strong> ajoutiez des dépenses.`;
@@ -1723,8 +1719,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vous</strong> soumettiez des dépenses.`;
@@ -1746,8 +1740,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vous</strong> ajoutiez un compte bancaire.`;
@@ -1767,8 +1759,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `le ${eta} de chaque mois` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vos</strong> dépenses soient automatiquement soumises${formattedETA}.`;
@@ -1784,8 +1774,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vous</strong> corrigiez les problèmes.`;
@@ -1801,8 +1789,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente de <strong>votre</strong> approbation des dépenses.`;
@@ -1818,8 +1804,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vous</strong> exportiez cette note de frais.`;
@@ -1835,8 +1819,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vous</strong> payiez les dépenses.`;
@@ -1852,8 +1834,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `En attente que <strong>vous</strong> terminiez la configuration d’un compte bancaire professionnel.`;
@@ -6892,9 +6872,9 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: 'Transports en commun et VTC',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: 'Agences de voyages',
},
- editRuleTitle: 'Modifier la règle de dépense',
+ editRuleTitle: 'Modifier la règle',
deleteRule: 'Supprimer la règle',
- deleteRuleConfirmation: 'Voulez-vous vraiment supprimer cette règle ?',
+ deleteRuleConfirmation: 'Êtes-vous sûr de vouloir supprimer cette règle ?',
},
},
planTypePage: {
@@ -7395,8 +7375,6 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
`a modifié la formule du nom de note de frais personnalisée en « ${newDefaultTitle} » (précédemment « ${oldDefaultTitle} »)`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `a pris la responsabilité de ${policyName} à la place de ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled: boolean) => `Soumission planifiée pour ${enabled ? 'activé' : 'désactivé'}`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 9f199e75..994ab490 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1690,8 +1690,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Sfondo modale',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1699,8 +1697,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> aggiunga delle spese.`;
@@ -1716,8 +1712,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> invii le note spese.`;
@@ -1739,8 +1733,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> aggiunga un conto bancario.`;
@@ -1760,8 +1752,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `il ${eta} di ogni mese` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che le <strong>tue</strong> spese vengano inviate automaticamente${formattedETA}.`;
@@ -1777,8 +1767,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> sistemi i problemi.`;
@@ -1794,8 +1782,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> approvi le spese.`;
@@ -1811,8 +1797,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> esporti questo report.`;
@@ -1828,8 +1812,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> rimborsi le spese.`;
@@ -1845,8 +1827,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `In attesa che <strong>tu</strong> finisca di configurare un conto bancario aziendale.`;
@@ -6855,7 +6835,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: 'Trasporti e ride sharing',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: 'Agenzie di viaggio',
},
- editRuleTitle: 'Modifica regola di spesa',
+ editRuleTitle: 'Modifica regola',
deleteRule: 'Elimina regola',
deleteRuleConfirmation: 'Sei sicuro di voler eliminare questa regola?',
},
@@ -7360,8 +7340,6 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
`ha modificato la formula del nome del report personalizzato in "${newDefaultTitle}" (in precedenza "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `ha assunto la proprietà di ${policyName} da ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled: boolean) => `Invio pianificato ${enabled ? 'abilitato' : 'disabilitato'}`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 3e96dcb4..f805be16 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1670,8 +1670,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'モーダルの背景',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1679,8 +1677,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `経費を追加するのを<strong>あなた</strong>が行うのを待機しています。`;
@@ -1696,8 +1692,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `経費の申請を<strong>あなた</strong>が行うのを待っています。`;
@@ -1719,8 +1713,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `銀行口座の追加を<strong>お待ちしています</strong>。`;
@@ -1740,8 +1732,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `毎月${eta}日に` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `<strong>あなたの</strong>経費が自動送信されるまでお待ちください${formattedETA}。`;
@@ -1757,8 +1747,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `問題の修正を<strong>あなた</strong>が行うのを待っています。`;
@@ -1774,8 +1762,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `経費の承認を<strong>あなた</strong>が行うのを待っています。`;
@@ -1791,8 +1777,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `このレポートのエクスポートを<strong>あなた</strong>が行うのを待っています。`;
@@ -1808,8 +1792,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `精算の支払いを<strong>あなた</strong>が行うのを待っています。`;
@@ -1825,8 +1807,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `ビジネス銀行口座の設定が完了するのを<strong>お客様</strong>の操作待ちです。`;
@@ -6780,7 +6760,7 @@ ${reportName}
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: '交通機関とライドシェア',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: '旅行代理店',
},
- editRuleTitle: '支出ルールを編集',
+ editRuleTitle: 'ルールを編集',
deleteRule: 'ルールを削除',
deleteRuleConfirmation: 'このルールを削除してもよろしいですか？',
},
@@ -7273,8 +7253,6 @@ ${reportName}
updatedDefaultTitle: (newDefaultTitle: string, oldDefaultTitle: string) => `カスタムレポート名の数式を「${newDefaultTitle}」に変更しました（以前は「${oldDefaultTitle}」）`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `${oldOwnerName}（${oldOwnerEmail}）から${policyName}の所有権を引き継ぎました`,
updatedAutoHarvesting: (enabled: boolean) => `${enabled ? '有効' : '無効'} の送信を予約しました`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 2515d379..9e98a445 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1686,8 +1686,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Modale achtergrond',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1695,8 +1693,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Wacht tot <strong>jij</strong> uitgaven toevoegt.`;
@@ -1712,8 +1708,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Er wordt gewacht tot <strong>jij</strong> declaraties indient.`;
@@ -1735,8 +1729,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Er wordt gewacht tot <strong>jij</strong> een bankrekening toevoegt.`;
@@ -1756,8 +1748,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `op de ${eta} van elke maand` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Wachten tot <strong>jouw</strong> uitgaven automatisch worden ingediend${formattedETA}.`;
@@ -1773,8 +1763,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `We wachten op <strong>jou</strong> om de problemen op te lossen.`;
@@ -1790,8 +1778,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Wacht tot <strong>jij</strong> de onkosten goedkeurt.`;
@@ -1807,8 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `We wachten op <strong>jou</strong> om dit rapport te exporteren.`;
@@ -1824,8 +1808,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Wacht tot <strong>jij</strong> onkosten betaalt.`;
@@ -1841,8 +1823,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Wachten tot <strong>je</strong> klaar bent met het instellen van een zakelijke bankrekening.`;
@@ -6836,7 +6816,7 @@ Voeg meer bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: 'Openbaar vervoer en ritdiensten',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: 'Reisbureaus',
},
- editRuleTitle: 'Uitgaveregel bewerken',
+ editRuleTitle: 'Regel bewerken',
deleteRule: 'Regel verwijderen',
deleteRuleConfirmation: 'Weet je zeker dat je deze regel wilt verwijderen?',
},
@@ -7338,8 +7318,6 @@ Voeg meer bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
updatedDefaultTitle: (newDefaultTitle: string, oldDefaultTitle: string) => `heeft aangepaste rapportnaamformule gewijzigd in "${newDefaultTitle}" (voorheen "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `heeft het eigendom van ${policyName} overgenomen van ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled: boolean) => `${enabled ? 'ingeschakeld' : 'uitgeschakeld'} gepland indienen`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 4276a2ef..8bc46997 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1686,8 +1686,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Tło modalu',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1695,8 +1693,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż to <strong>ty</strong> dodasz wydatki.`;
@@ -1712,8 +1708,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż <strong>Ty</strong> zgłosisz wydatki.`;
@@ -1735,8 +1729,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż <strong>dodasz</strong> konto bankowe.`;
@@ -1756,8 +1748,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `${eta}. dnia każdego miesiąca` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Oczekiwanie, aż <strong>twoje</strong> wydatki zostaną automatycznie przesłane${formattedETA}.`;
@@ -1773,8 +1763,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż <strong>ty</strong> naprawisz problemy.`;
@@ -1790,8 +1778,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż <strong>ty</strong> zatwierdzisz wydatki.`;
@@ -1807,8 +1793,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż to <strong>ty</strong> wyeksportujesz ten raport.`;
@@ -1824,8 +1808,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż <strong>ty</strong> zapłacisz wydatki.`;
@@ -1841,8 +1823,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Czekamy, aż <strong>Ty</strong> skończysz zakładać firmowe konto bankowe.`;
@@ -6827,7 +6807,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: 'Transport i przejazdy współdzielone',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: 'Biura podróży',
},
- editRuleTitle: 'Edytuj regułę wydatków',
+ editRuleTitle: 'Edytuj regułę',
deleteRule: 'Usuń regułę',
deleteRuleConfirmation: 'Na pewno chcesz usunąć tę regułę?',
},
@@ -7328,8 +7308,6 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
`zmieniono formułę nazwy niestandardowego raportu na „${newDefaultTitle}” (wcześniej „${oldDefaultTitle}”)`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `przejął(a) własność ${policyName} od ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled: boolean) => `Zaplanowane przesłanie ${enabled ? 'włączone' : 'wyłączone'}`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index c580fde7..97857564 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1683,8 +1683,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: 'Pano de fundo do modal',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1692,8 +1690,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando <strong>você</strong> adicionar despesas.`;
@@ -1709,8 +1705,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando <strong>você</strong> enviar despesas.`;
@@ -1732,8 +1726,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Esperando <strong>você</strong> adicionar uma conta bancária.`;
@@ -1753,8 +1745,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `no dia ${eta} de cada mês` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando as <strong>suas</strong> despesas serem enviadas automaticamente${formattedETA}.`;
@@ -1770,8 +1760,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando <strong>você</strong> corrigir os problemas.`;
@@ -1787,8 +1775,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando <strong>você</strong> aprovar as despesas.`;
@@ -1804,8 +1790,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando <strong>você</strong> exportar este relatório.`;
@@ -1821,8 +1805,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando <strong>você</strong> pagar as despesas.`;
@@ -1838,8 +1820,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `Aguardando <strong>você</strong> concluir a configuração de uma conta bancária empresarial.`;
@@ -6834,7 +6814,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: 'Transporte público e carros de aplicativo',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: 'Agências de viagens',
},
- editRuleTitle: 'Editar regra de gasto',
+ editRuleTitle: 'Editar regra',
deleteRule: 'Excluir regra',
deleteRuleConfirmation: 'Tem certeza de que quer excluir esta regra?',
},
@@ -7331,8 +7311,6 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
`alterou a fórmula do nome do relatório personalizado para "${newDefaultTitle}" (antes "${oldDefaultTitle}")`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `assumiu a propriedade de ${policyName} de ${oldOwnerName} (${oldOwnerEmail})`,
updatedAutoHarvesting: (enabled: boolean) => `Envio agendado ${enabled ? 'ativado' : 'desativado'}`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 45e8c9d2..3c252213 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1638,8 +1638,6 @@ const translations: TranslationDeepObject<typeof en> = {
backdropLabel: '模态背景',
},
nextStep: {
- // All nextStep.message functions share a common positional signature (actor, actorType, eta, etaType) for type compatibility, so unused params are expected
- /* eslint-disable @typescript-eslint/no-unused-vars */
message: {
[CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: (
actor: string,
@@ -1647,8 +1645,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>添加报销。`;
@@ -1664,8 +1660,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>提交报销。`;
@@ -1687,8 +1681,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>添加银行账户。`;
@@ -1708,8 +1700,6 @@ const translations: TranslationDeepObject<typeof en> = {
if (eta) {
formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? `在每个月的 ${eta} 日` : ` ${eta}`;
}
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你的</strong>报销费用自动提交${formattedETA}。`;
@@ -1725,8 +1715,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>来解决这些问题。`;
@@ -1742,8 +1730,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>审批报销。`;
@@ -1759,8 +1745,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>导出此报表。`;
@@ -1776,8 +1760,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>报销费用。`;
@@ -1793,8 +1775,6 @@ const translations: TranslationDeepObject<typeof en> = {
_eta?: string,
_etaType?: ValueOf<typeof CONST.NEXT_STEP.ETA_TYPE>,
) => {
- // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive
- // eslint-disable-next-line default-case
switch (actorType) {
case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER:
return `正在等待<strong>你</strong>完成设置企业银行账户。`;
@@ -6659,7 +6639,7 @@ ${reportName}
[CONST.SPEND_RULES.CATEGORIES.TRANSIT_AND_RIDESHARE]: '公共交通和网约车',
[CONST.SPEND_RULES.CATEGORIES.TRAVEL_AGENCIES]: '旅行社',
},
- editRuleTitle: '编辑消费规则',
+ editRuleTitle: '编辑规则',
deleteRule: '删除规则',
deleteRuleConfirmation: '确定要删除此规则吗？',
},
@@ -7142,8 +7122,6 @@ ${reportName}
updatedDefaultTitle: (newDefaultTitle: string, oldDefaultTitle: string) => `将自定义报表名称公式更改为“${newDefaultTitle}”（之前为“${oldDefaultTitle}”）`,
updatedOwnership: (oldOwnerEmail: string, oldOwnerName: string, policyName: string) => `从 ${oldOwnerName}（${oldOwnerEmail}）接管了 ${policyName} 的所有权`,
updatedAutoHarvesting: (enabled: boolean) => `已计划提交 ${enabled ? '已启用' : '已禁用'}`,
- // This function requires 11 params to match the budget notification data model; reducing further would hurt readability
- // eslint-disable-next-line @typescript-eslint/max-params
updatedIndividualBudgetNotification: (
budgetAmount: string,
budgetFrequency: string,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
melvin-bot
bot
requested review from
bernhardoj and
flaviadefaria
and removed request for
a team
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
Hmm not sure why Polyglot Parrot is making all those changes to the language files 🤔 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0d84e1588
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
cead22
reviewed
Apr 8, 2026
src/pages/workspace/rules/SpendRules/SpendRuleMaxAmountPage.tsx
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Allows editing and deleted spend rules.
Fixed Issues
$ #86522
Tests
Pre-condition:
Workspaces > RulesSpend ruleOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Screen.Recording.2026-04-08.at.11.02.06.AM.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari