[No QA] decomp-composer 1: add composer's context#87247
[No QA] decomp-composer 1: add composer's context#87247cristipaval merged 3 commits intoExpensify:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c54e2fb97a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Only invalid comments from Codex on memoization. |
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@adhorodyski Could you please confirm whether this requires review? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7bd996b16
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Hey @Krishna2323 sorry the ping, @DylanDylann has been looking over the decomposition of the reportscreen |
Reviewer Checklist
|
|
@cristipaval are we good for a merge here? |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.55-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required. This PR adds internal React context/provider infrastructure for the composer decomposition (contexts, provider, focus hook). It is purely additive scaffolding with no user-facing changes — no UI, feature, setting, or workflow changes that would need to be reflected in help site articles under |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.57-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR adds internal React context/provider infrastructure ( |
@DylanDylann @rlinoz
Explanation of Change
PR 1 of 6 in the ReportActionCompose decomposition series (issue #87097).
Adds the context/provider foundation for the new compound Composer architecture. No existing code is modified — this is purely additive.
Three new files under
src/pages/home/report/ReportActionCompose/:ComposerTextContext,ComposerStateContext,ComposerSendStateContext,ComposerActionsContext,ComposerSendActionsContext,ComposerMetaContext. Splitting by change frequency limits re-renders to only the subscribers that actually care about a given slice of state.ReportActionCompose.Fixed Issues
$ #87097
PROPOSAL:
Tests
No tests here, this is only adding code we'll use in followup PRs as per the linked issue.
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari