Deferring Trie Build by elirangoshen · Pull Request #87253 · Expensify/App

elirangoshen · 2026-04-07T13:10:32Z

Explanation of Change

Defers the emoji Trie build from app startup to first use. Previously, LocaleContextProvider eagerly called buildEmojisTrie right after importing the emoji locale data, adding to startup time.

Now, the trie is built lazily via getEmojiTrie() on the first call to replaceEmojis or suggestEmojis in EmojiUtils—i.e., when the user actually interacts with emoji shortcodes.

Fixed Issues

[Due for payment 2026-04-16] [$250] Optimize EmojiTrie Build Performance #86759

Tests

Open the app and verify it loads without errors
Open any chat and type :smile to trigger emoji suggestions
Verify emoji suggestions appear correctly
Send a message with :thumbsup: and verify it gets replaced with the emoji
Switch locale to Spanish and repeat steps 2–4

Verify that no errors appear in the JS console

Offline Tests

N/A — This change only affects when the emoji trie is built (deferred from startup to first use). No network dependency.

QA Steps

[No QA] — Performance-only change that defers emoji trie construction. No user-facing behavior change.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-04-07T13:11:16Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0a1308e12

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/EmojiTrie.ts

codecov · 2026-04-07T13:34:01Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/LocaleContextProvider.tsx	`83.33% <ø> (-0.39%)`	⬇️
src/libs/EmojiTrie.ts	`100.00% <100.00%> (ø)`
src/libs/EmojiUtils.tsx	`71.83% <100.00%> (ø)`
... and 150 files with indirect coverage changes

shubham1206agra · 2026-04-07T19:15:13Z

src/components/LocaleContextProvider.tsx

        importEmojiLocale(normalizedLocale).then(() => {
            endSpan(CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT);


@elirangoshen Why are we importing emoji files when we are not even using them immediately?

Lets defer this import if possible

shubham1206agra · 2026-04-07T19:16:21Z

src/libs/EmojiTrie.ts

    }
+    // Don't build and cache the trie if locale emoji data hasn't been loaded yet,
+    // otherwise we'd permanently cache a trie with only English fallback names.
+    if (locale !== CONST.LOCALES.DEFAULT && !localeEmojis[locale]) {


@elirangoshen Maybe we should import the emoji file if this condition is met.

Julesssss · 2026-04-07T21:45:56Z

src/libs/EmojiTrie.ts

+    startSpan(CONST.TELEMETRY.SPAN_LOCALE.EMOJI_TRIE_BUILD, {
+        name: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_TRIE_BUILD,
+        op: CONST.TELEMETRY.SPAN_LOCALE.EMOJI_TRIE_BUILD,
+    });


Just thinking if this can be parented dynamically or must be orphaned. I think no parent makes sense 👍

joekaufmanexpensify · 2026-04-08T15:42:23Z

No product review needed

roryabraham · 2026-04-08T23:26:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

OSBotify · 2026-04-08T23:49:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-09T00:33:09Z

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-09T00:37:33Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87253.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8d038ed-25f65b6-7e2e60065770b134e8808e0a5fa0864d786f24d0/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8d038ed-25f65b6-0d1dfdeaa58da566fcacad947a411b53f5bdf3b3/index.html

Web 🕸️
https://87253.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-09T00:58:33Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.55-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-09T01:02:46Z

No help site changes are required for this PR.

This is a performance-only change that defers the internal emoji Trie data structure build from app startup to first use. There are no user-facing behavior changes, no new or removed features, and no changes to UI text, settings, or labels — nothing that would need to be reflected in docs/articles.

jponikarchuk · 2026-04-09T05:49:05Z

Deploy Blocker #87453 was identified to be related to this PR.

jponikarchuk · 2026-04-09T05:52:16Z

This PR failing because of the issue #87453
This issue is reproducible in: All platforms

deferring trie build

e0a1308

elirangoshen requested review from a team as code owners April 7, 2026 13:10

melvin-bot bot assigned elirangoshen Apr 7, 2026

melvin-bot bot requested review from deetergp and joekaufmanexpensify and removed request for a team April 7, 2026 13:10

adding span

f42e6f3

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

src/libs/EmojiTrie.ts Show resolved Hide resolved

pr fix

939d129

elirangoshen mentioned this pull request Apr 7, 2026

[Due for payment 2026-04-16] [$250] Optimize EmojiTrie Build Performance #86759

Open

elirangoshen mentioned this pull request Apr 7, 2026

[Metrics] Improve App Start Time Performance #77171

Open

roryabraham previously approved these changes Apr 7, 2026

View reviewed changes

mountiny requested a review from shubham1206agra April 7, 2026 18:26

shubham1206agra reviewed Apr 7, 2026

View reviewed changes

Julesssss reviewed Apr 7, 2026

View reviewed changes

pr fix

c5fc40a

elirangoshen dismissed roryabraham’s stale review via c5fc40a April 8, 2026 10:00

elirangoshen requested review from Julesssss and shubham1206agra April 8, 2026 10:24

joekaufmanexpensify removed their request for review April 8, 2026 15:42

Julesssss approved these changes Apr 8, 2026

View reviewed changes

roryabraham approved these changes Apr 8, 2026

View reviewed changes

roryabraham merged commit 8d038ed into Expensify:main Apr 8, 2026
31 of 36 checks passed

OSBotify mentioned this pull request Apr 9, 2026

Deploy Checklist: New Expensify 2026-04-09 #87435

Open

63 tasks

jponikarchuk mentioned this pull request Apr 9, 2026

Chat-:thumbsup: doesn't replaced with emoji. #87453

Open

7 tasks

roryabraham mentioned this pull request Apr 9, 2026

Revert "Deferring Trie Build" #87498

Draft

		importEmojiLocale(normalizedLocale).then(() => {
		endSpan(CONST.TELEMETRY.SPAN_LOCALE.EMOJI_IMPORT);

Conversation

elirangoshen commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline Tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 7, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov bot commented Apr 7, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shubham1206agra Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

elirangoshen Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

elirangoshen Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Julesssss Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Apr 8, 2026

Uh oh!

roryabraham commented Apr 8, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

OSBotify commented Apr 9, 2026

Uh oh!

MelvinBot commented Apr 9, 2026

Uh oh!

jponikarchuk commented Apr 9, 2026

Uh oh!

jponikarchuk commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

elirangoshen commented Apr 7, 2026 •

edited

Loading

codecov bot commented Apr 7, 2026 •

edited by github-actions bot

Loading

shubham1206agra Apr 7, 2026 •

edited

Loading

Julesssss Apr 7, 2026 •

edited

Loading