Call getThumbnailAndImageURIs unconditionally in ReceiptCell#87417
Draft
Call getThumbnailAndImageURIs unconditionally in ReceiptCell#87417
Conversation
ReceiptCell guarded the call to getThumbnailAndImageURIs behind a check on receipt.source, which meant receipts with only receipt.filename (e.g., receipts added via email or billing) never hit the filename-based fallback in getThumbnailAndImageURIs. This caused missing thumbnails in the Expenses tab list view even though detail/preview views worked fine. Co-authored-by: Daniel Gale-Rosen <dangrous@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
ReceiptCell(used in the Expenses tab list view) guarded the call togetThumbnailAndImageURIsbehind a check onreceipt.source. Whenreceipt.sourcewas missing butreceipt.filenameexisted (e.g., receipts added via email or billing), the filename-based fallback insidegetThumbnailAndImageURIswas never reached, causing missing thumbnails.This PR removes the guard and calls
getThumbnailAndImageURIsunconditionally — the same pattern used byTransactionPreviewContentandMoneyRequestReceiptView— so theconstructReceiptSourceFromFilenamefallback can activate when needed.Fixed Issues
$ #86592
PROPOSAL: #86592 (comment)
Tests
receipt.sourceis empty butreceipt.filenameis set)Offline tests
N/A — This change only affects how receipt thumbnail URLs are resolved from existing transaction data. No network requests are added or modified.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari