Do not append & to internal Expenisfy URLs that have a # symbol.

[johnmlee101]

Details

Some internal links use hash params which don't expect ? in the URL. Instead they should be continued via & so this will fix the issue of some internal links appending data like the token to data fields rather than as a new param.

Fixed Issues

$ #9416

Tests

IF TESTING ON STAGING REPLACE www WITH staging IN THE URL

1. Send a message with the following contents:
   https://www.expensify.com/api.php
   https://www.expensify.com/api.php?test=1
   https://www.expensify.com/api.php#123
   https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=blob%3A%22Expensiworks_CaptureAgentActivity%22%20AND%20blob%3A%22isDoneWorking%3A%20'true'%22%20AND%20email%3A%22monte%40expensify.com%22%20AND%20timestamp%3A%5B2022-05-25T12%3A00%20TO%202022-05-25T14%3A00%5D

2. See that clicking each will result in the following in the end-point URL

https://www.expensify.com/api.php

AuthToken is appended with ?authToken=

https://www.expensify.com/api.php?test=1

AuthToken is appended with &authToken=

https://www.expensify.com/api.php#123

AuthToken is appended with &authToken=

https://www.expensify.com/_devportal/tools/logSearch/#sort=asc&size=10000&query=blob%3A%22Expensiworks_CaptureAgentActivity%22%20AND%20blob%3A%22isDoneWorking%3A%20'true'%22%20AND%20email%3A%22monte%40expensify.com%22%20AND%20timestamp%3A%5B2022-05-25T12%3A00%20TO%202022-05-25T14%3A00%5D

AuthToken is appended with &authToken= as is not part of the log request

• Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-06-14.at.10.47.11.AM.mov

Mobile Web

Desktop

iOS

Android

[johnmlee101]

Bump!

[aldo-expensify]

Sorry for the slowness @johnmlee101

This solutions considers # and ? equivalents when appending the new param authToken. I understand the reasoning for the logsearch url because it weirdly uses # as a start for paramenters, but this is not the normal thing.

This could break if there was an olddot url using # to make you scroll to a specific node, but maybe we never do that? if we never do that, this fix should be fine.

[johnmlee101]

This could break if there was an olddot url using # to make you scroll to a specific node, but maybe we never do that? if we never do that, this fix should be fine.

Yeah I scanned for any URLs that link to olddot baked into Expensify/App already and couldn't find any URLs that used # in that way, so I thought this was safe enough to implement.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @aldo-expensify in version: 1.1.78-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @sketchydroide in version: 1.1.78-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅