Skip to content

Conversation

@nkuoch
Copy link
Contributor

@nkuoch nkuoch commented Jul 2, 2022

Details

Refactor VBBA flow for 2 1st steps: BankAccountStep and CompanyStep

Fixed Issues

Tests

QA Steps

See screenshots

Screenshots

Web

Go to Workspace > Connect Bank Account
image

Click on Connect Online with Plaid
image

Select Chase, user_good, pass_good
image

Select Plaid Saving and submit
image

Submit manual form with no account numbers and make sure you see errors.
image

Enter routingNumber 011401533 and accountNumber 1111222233331112. You should see this error on submission:
image

Change accountNumber with 1111222233331111. Submission should work.

Submitting the Company Step without filling the fields should show errors:
image

Fill it up with Alberta Bobbeth Charleson and 123456789. Submit and you should reach the RequestorStep

Reload the page on /workspace/DD3B9995F6CD682C/bank-account

You should see
image

Click on Continue with Setup

Check that previous steps were filled with previous info.

Proceed with all steps.

@nkuoch nkuoch self-assigned this Jul 2, 2022
@nkuoch nkuoch force-pushed the nat-VBBAnewAPIs branch 2 times, most recently from d986a19 to 1274748 Compare July 4, 2022 10:28
@nkuoch nkuoch changed the base branch from main to nat-plaidNewAPI July 4, 2022 11:13
@nkuoch nkuoch force-pushed the nat-VBBAnewAPIs branch 9 times, most recently from 46e76e6 to 017f40c Compare July 6, 2022 11:45
@nkuoch nkuoch changed the title [WIP] Refactor VBBA setup flow with new APIs [WIP] Refactor VBBA setup flow with new APIs (BankAccountStep and CompanyStep) Jul 6, 2022
@nkuoch nkuoch force-pushed the nat-VBBAnewAPIs branch 2 times, most recently from 5a1e431 to 8106e53 Compare July 6, 2022 13:22
@nkuoch nkuoch changed the base branch from nat-plaidNewAPI to main July 6, 2022 13:32
@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2022

Looks like you modified deprecatedAPI.js! To be clear, you should not be adding any code to this file.

Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands.

Unsure if your change is okay? Drop a note in #expensify-open-source!

@nkuoch nkuoch force-pushed the nat-VBBAnewAPIs branch from 8106e53 to e2cc73c Compare July 6, 2022 13:33
@nkuoch nkuoch changed the base branch from main to nat-plaidNewAPI July 6, 2022 13:33
@nkuoch nkuoch force-pushed the nat-plaidNewAPI branch from 2eb2a9d to c97adff Compare July 6, 2022 13:42
@nkuoch
Copy link
Contributor Author

nkuoch commented Jul 6, 2022

@MariaHCD adding you as an assignee as you're likely to take it over and commit on it while I'm gone, after the design doc is approved

@nkuoch nkuoch force-pushed the nat-VBBAnewAPIs branch 7 times, most recently from 070a385 to 9cea873 Compare July 7, 2022 09:07
@nkuoch nkuoch force-pushed the nat-VBBAnewAPIs branch 2 times, most recently from 0239002 to 22199cc Compare July 7, 2022 21:26
Base automatically changed from nat-plaidNewAPI to main July 19, 2022 17:29
@nkuoch nkuoch force-pushed the nat-VBBAnewAPIs branch 3 times, most recently from 9585b44 to 965a4bc Compare September 8, 2022 10:47
@nkuoch nkuoch changed the title [WIP] Refactor VBBA setup flow with new APIs (BankAccountStep and CompanyStep) [WIP] Refactor VBBA setup flow with new API ConnectBankAccountWithPlaid Sep 20, 2022
@nkuoch nkuoch changed the title [WIP] Refactor VBBA setup flow with new API ConnectBankAccountWithPlaid Refactor VBBA setup flow with new API ConnectBankAccountWithPlaid Sep 21, 2022
@nkuoch
Copy link
Contributor Author

nkuoch commented Sep 21, 2022

Closing in favor of #11162 because my old commits from my old stolen laptop became unverified

@nkuoch nkuoch closed this Sep 21, 2022
@roryabraham roryabraham deleted the nat-VBBAnewAPIs branch November 2, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants