fix: export url website regex#475
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
melvin-bot
bot
requested review from
luacmartins
and removed request for
a team
|
@MonilBhavsar Are you ok with the exports here or should we move this to a new file? |
|
Let's make a new file URL's and have everything related to URLs in it |
|
I have read the CLA Document and I hereby sign the CLA |
|
@parasharrajat @MonilBhavsar I've updated my PR, pls let me know your thought. Thanks |
lib/ExpensiMark.js
Outdated
| return replacedText; | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
What's this change?
Same for another file
|
@parasharrajat please review |
lib/ExpensiMark.js
Outdated
| const URL_PARAM_REGEX = `(?:\\?${addEscapedChar('[-\\w$@.+!*()\\/,=%{}:;\\[\\]\\|_]')}+)?`; | ||
| const URL_FRAGMENT_REGEX = `(?:#${addEscapedChar('[-\\w$@.+!*()[\\],=%;\\/:~]')}*)?`; | ||
| const URL_REGEX = `(${URL_WEBSITE_REGEX}${URL_PATH_REGEX}(?:${URL_PARAM_REGEX}|${URL_FRAGMENT_REGEX})*)`; | ||
| import { URL_REGEX } from './Url'; |
There was a problem hiding this comment.
| import { URL_REGEX } from './Url'; | |
| import {URL_REGEX} from './Url'; |
lib/Url.js
Outdated
| URL_PARAM_REGEX, | ||
| URL_FRAGMENT_REGEX, | ||
| URL_REGEX | ||
| } No newline at end of file |
There was a problem hiding this comment.
Add a newline at the end of the file.
|
@parasharrajat I've fixed my PR. Thanks for your review |
|
@tienifr one lint error to resolve |
|
@MonilBhavsar Can you help to trigger tests again? Thanks |
|
@tienifr this change will be deployed when this PR is merged Expensify/App#12925 |
3 participants
@parasharrajat @MonilBhavsar
I'll export URL_WEBSITE_REGEX from ExpensiMark
Fixed Issues
$ Expensify/App#11810
Tests
QA