Skip to content

Fixed phone number regex#677

Merged
grgia merged 1 commit intoExpensify:mainfrom
Pujan92:fix/37723
Apr 4, 2024
Merged

Fixed phone number regex#677
grgia merged 1 commit intoExpensify:mainfrom
Pujan92:fix/37723

Conversation

@Pujan92
Copy link
Contributor

@Pujan92 Pujan92 commented Apr 4, 2024

Corrected the phone number regex by adding the startswith(^) and endswith($) characters. Follow-up of PR #672
cc: @grgia

Fixed Issues

$ Expensify/App#37723
Expensify/App#37723 (comment)

Tests

  1. Unit tests have been updated in tests/Str-test.js to cover invalid number scenario.
Screen.Recording.2024-04-04.at.21.34.07.mov

@Pujan92 Pujan92 requested a review from a team as a code owner April 4, 2024 16:05
@github-actions
Copy link

github-actions bot commented Apr 4, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team April 4, 2024 16:06
@Pujan92
Copy link
Contributor Author

Pujan92 commented Apr 4, 2024

I have read the CLA Document and I hereby sign the CLA

@grgia grgia merged commit 13de5b0 into Expensify:main Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants