Modify mention user and mention report extras field names in ExpensiMark htmlToText and htmlToMarkdown rules#708
Conversation
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
mollfpr
left a comment
mollfpr
left a comment
There was a problem hiding this comment.
It seems we have a test failure.
I'll be expecting the changes to minimal as it could so we don't break anything here.
lib/ExpensiMark.js
Outdated
| return `@${extras.accountIdToName[g1]}`; | ||
| return `@${accountToNameMap[g1]}`; | ||
| } | ||
| return Str.removeSMSDomain(g2) |
There was a problem hiding this comment.
What's the purpose of these changes?
There was a problem hiding this comment.
The failling tests are because I didn't changes the fields in the test files yet, I am sorry.
For accountToNameMap, I am following the pattern in the file for reportToNameMap:
expensify-common/lib/ExpensiMark.js
Line 545 in 321e4a7
accountToNameMap is just a variable that store extras.accountIdToName. It is the same thing:
expensify-common/lib/ExpensiMark.js
Line 481 in 321e4a7
Should I revert it?
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
|
@mollfpr The failling tests are because I didn't changes the fields in the test files yet, I am sorry. Should be fine now... |
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>
|
@mollfpr I have reverted the changes. |
|
🚀Published to npm in v2.0.3 |
3 participants
This PR changes field name of extras in ExpensiMark to fix type check fails.
Modify mention user and mention report extras field names in ExpensiMark htmlToText and htmlToMarkdown rules
Fixed Issues
$ Expensify/App#40928
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
typecheck on expensify/App should run successfully
What tests did you perform that validates your changed worked?
I have tested it on my other PR, thread report from report action that contains mention room and mention user should display report name properly in header report and in LHN.
QA
What does QA need to do to validate your changes?
N/A
What areas to they need to test for regressions?
N/A