Use legacy worker for prev. IOS#43
Merged
mountiny merged 1 commit intoExpensify:mainfrom Jan 17, 2025
Merged
Conversation
rezkiy37
changed the title
Contributor
|
@gedu did you see this? |
|
is it an issue from iOS? why last pdf is not supported? |
Contributor
Author
I guess the latest PDF.js worker does not support the previous IOS Safari. It is an excellent point. I think we need to make a sort of hot fix right now and return the legacy worker, but I am going to investigate and apply the current worker as the next step. |
Contributor
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
A bug was detected in the previous IOS version -
17.x. Unfortunately, the latest PDF.js worker does not render files. I am returning the legacy one.Related Issues
Expensify/App#55176
Manual Tests
Screenshots
Linked PRs
Revert - #39, #40