Prevent subscribing to keycommands on non browser environments #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
54 tasks
luacmartins
previously approved these changes
Feb 6, 2023
luacmartins
reviewed
Feb 6, 2023
Contributor
luacmartins
left a comment
luacmartins
left a comment
There was a problem hiding this comment.
@azimgd can you actually bump the package version as well?
Contributor
Author
|
Sure. Btw, are you using: |
Contributor
Author
|
@luacmartins done. |
Contributor
|
@azimgd I'm not. We usually follow this process to release our packages, or we built a GH action like this one to automate the publishing process. |
luacmartins
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(electron) webpack build includes const file during compilation, hence build fails when document is used outside of main process.