Caret positioning & scrolling on enter#247
Merged
BartoszGrajdek merged 1 commit intomainfrom Mar 27, 2024
Merged
Conversation
Contributor
Author
|
I still need to test it in the Expensify App, but there shouldn't be any problems so this PR is open to review |
BartoszGrajdek
commented
Mar 27, 2024
Comment on lines
+48
to
+49
| 'es/no-nullish-coalescing-operators': 'off', | ||
| 'es/no-optional-chaining': 'off', |
Contributor
Author
There was a problem hiding this comment.
These rules are already disabled in the Expensify app, so we don't need them
BartoszGrajdek
changed the title
enter
BartoszGrajdek
changed the title
enterenter
tomekzaw
approved these changes
Mar 27, 2024
Contributor
Author
|
Tested in Expensify and it's working fine now ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes weird cursor / scrolling behaviour where you press
enterand input doesn't scroll or is scrolling incorrectlyRelated Issues
GH_LINK
Manual Tests
Test in 2 scenarios:
numberOfLinesinexample/src/App.tsxCheck how scrolling/cursor behaves when you:
enterin front of line of text / markdown blockenterafter line of text / markdown blockenterat the end of inputenterat the beginning of inputLinked PRs
Expensify/App#38152