Improve performance on iOS #356
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksg
force-pushed
the
@maksg/performance-fixes-ios
branch
3 times, most recently
from
2bc06d9 to
bc558d9
Compare
tomekzaw
reviewed
May 27, 2024
maksg
force-pushed
the
@maksg/performance-fixes-ios
branch
from
bc558d9 to
5e5985a
Compare
maksg
force-pushed
the
@maksg/performance-fixes-ios
branch
from
274fc06 to
8a5ef00
Compare
maksg
force-pushed
the
@maksg/performance-fixes-ios
branch
from
8a5ef00 to
a2f7e92
Compare
This was referenced Sep 12, 2024
50 tasks
Collaborator
|
This PR fixes an issue with Screen.Recording.2024-09-12.at.11.55.09.mov |
Collaborator
|
❌ Regression found: text suggestions are instantly converted into regular text Screen.Recording.2024-09-12.at.11.57.07.mov |
Collaborator
|
Regression found: Screen.Recording.2024-09-18.at.09.42.29.mov |
maksg
force-pushed
the
@maksg/performance-fixes-ios
branch
from
39b7432 to
0023863
Compare
Contributor
Author
|
Fixed all the issues except this. Possibly it's a regression but needs to be looked at. I think it happens only after emojis because other than that the autocomplete seems to work. Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-10-14.at.17.48.10.mp4 |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
On iOS TextView was very slow and unreliable. This PR improves the performance by quite a lot by removing some unnecessary code and simplifying parsing logic.