Skip to content

Unable pasting photos and styled text#369

Merged
BartoszGrajdek merged 2 commits intoExpensify:mainfrom
zfurtak:@zfurtak/fix-pasting-photos
Jun 25, 2024
Merged

Unable pasting photos and styled text#369
BartoszGrajdek merged 2 commits intoExpensify:mainfrom
zfurtak:@zfurtak/fix-pasting-photos

Conversation

@zfurtak
Copy link
Contributor

@zfurtak zfurtak commented Jun 6, 2024

Details

The default paste behaviour is overridden by inserting a `text/plain' value.

@github-actions
Copy link

github-actions bot commented Jun 6, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@zfurtak
Copy link
Contributor Author

zfurtak commented Jun 6, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@BartoszGrajdek BartoszGrajdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍🏻

I still need to test it in the E/App - that's something I'll handle tomorrow. If @Skalakid has a moment it would be great if he tested the styled text case - I can't get it working even on the main 🤷🏻‍♂️

@zfurtak
Copy link
Contributor Author

zfurtak commented Jun 7, 2024

@BartoszGrajdek just keep in mind that in the E/App this error is possibly handled, as I tried to reproduce this case (at least with photos) there and I couldn't do it 😉

Copy link
Contributor

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 This PR is also fixing pasting styled text case

@BartoszGrajdek
Copy link
Contributor

Once we fix current problems in the lib we'll merge this

@BartoszGrajdek BartoszGrajdek merged commit 2ab7e30 into Expensify:main Jun 25, 2024
@hannojg
Copy link
Contributor

hannojg commented Jul 5, 2024

Hey, I just tested these changes in NewDot and there is a console error and the text gets pasted twice:

Screenshot 2024-07-05 at 14 01 17

Screen.Recording.2024-07-05.at.13.35.39.mov

@BartoszGrajdek
Copy link
Contributor

Hi @hannojg we know about that problem - @Skalakid is working on a fix to solve it. It's related to some custom pasting logic inside of E/App and we'll have to fix it there before we bump the version to >0.1.91.

Thank you for your perceptiveness 🙌🏻

@Skalakid Skalakid mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants