fix: update contentSelection ref after text change#370
Merged
BartoszGrajdek merged 1 commit intoExpensify:mainfrom Jun 7, 2024
Merged
fix: update contentSelection ref after text change#370BartoszGrajdek merged 1 commit intoExpensify:mainfrom
BartoszGrajdek merged 1 commit intoExpensify:mainfrom
Conversation
Signed-off-by: dominictb <tb-dominic@outlook.com>
Contributor
Author
|
@BartoszGrajdek to review here |
Contributor
|
Testing! |
BartoszGrajdek
approved these changes
Jun 7, 2024
Contributor
BartoszGrajdek
left a comment
BartoszGrajdek
left a comment
There was a problem hiding this comment.
LGTM! Fixed the bug 👍🏻
tomekzaw
approved these changes
Jun 7, 2024
Contributor
|
Thank you for a quick reaction @dominictb 🙌🏻 |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Expensify/App#41137 (comment)
Related Issues
Expensify/App#41137
Manual Tests
Tested on Firefox
Screen.Recording.2024-06-07.at.14.48.34.mov
Linked PRs
Expensify/App#42622