Fix selection issue for text containing emoji#416
Merged
tomekzaw merged 1 commit intoExpensify:mainfrom Jul 17, 2024
Merged
Conversation
mollfpr
approved these changes
Jul 8, 2024
|
Friendly bump @tomekzaw |
tomekzaw
approved these changes
Jul 17, 2024
Collaborator
tomekzaw
left a comment
tomekzaw
left a comment
There was a problem hiding this comment.
I confirm this PR fixes the selection problem on iOS Fabric.
hannojg
pushed a commit
to margelo/react-native-live-markdown
that referenced
this pull request
Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Emoji characters are automatically assigned an
AppleColorEmojiNSFontand the original font is moved toNSOriginalFont.We need to remove these attributes before comparison.
Related Issues
$ Expensify/App#44495
PROPOSAL: Expensify/App#44495 (comment)
Manual Tests
Expected Result:
Able to select a word.
Screen recordings
Before:
before.mp4
After:
after.mp4
Linked PRs