Merged
Conversation
BartoszGrajdek
previously approved these changes
Aug 22, 2024
Contributor
BartoszGrajdek
left a comment
There was a problem hiding this comment.
Code LGTM, tested example app and it didn't break anything.
LMK if you want me to test it in E/App as well 😄
50 tasks
BartoszGrajdek
previously approved these changes
Aug 23, 2024
Contributor
Author
|
E/App bug: Cursor position is wrong when starting typing a message when input isn't focused Screen.Recording.2024-08-23.at.16.18.04.mov |
Contributor
Author
|
The above bug has been fixed. @BartoszGrajdek can you review this PR again, please 🙏 |
BartoszGrajdek
approved these changes
Aug 27, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR contain follow up fixes to the bugs reported in E/App under the Live Markdown refactor PR. It changes and simplifies the selection event logic, so all cases when user selects the text are caught. To achieve this we had to remove standard
selectionStartandselectionEndprops and replace them with customselection.startandselection.end. SettingselectionStartandselectionEndvalues breaks the nativeonSelectevent handlerRelated Issues
GH_LINK
Manual Tests
CutLinked PRs
Expensify/App#45150