Skip to content

Conversation

@tomekzaw
Copy link
Collaborator

@tomekzaw tomekzaw commented Aug 30, 2024

Details

This PR renames type Range to MarkdownRange to avoid confusion with type Range from Web API, by the way also used in the codebase.

Related Issues

GH_LINK

Manual Tests

Linked PRs

Skalakid
Skalakid previously approved these changes Aug 30, 2024
Copy link
Contributor

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Btw in parserUtils we have the same MarkdownRange type, so it would be nice to merge them into one

BartoszGrajdek
BartoszGrajdek previously approved these changes Aug 30, 2024
@tomekzaw tomekzaw dismissed stale reviews from BartoszGrajdek and Skalakid via 17687fd August 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants