Skip to content

Conversation

@chrispader
Copy link
Contributor

@chrispader chrispader commented Jun 28, 2025

@roryabraham

Details

Adds support support for 16KB memory page sizes on Android.

Related Issues

Expensify/App#63871

Manual Tests

Make sure the app builds.

Linked PRs

Expensify/App#64640

@github-actions
Copy link

github-actions bot commented Jun 28, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@tomekzaw
Copy link
Collaborator

@chrispader Thanks for the PR! Please sign the CLA so we can merge it.

I know what ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON does but could you please explain why we also need to set jniLibs.useLegacyPackaging to true as well?

@chrispader
Copy link
Contributor Author

I know what ANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON does but could you please explain why we also need to set jniLibs.useLegacyPackaging to true as well?

Oh yea sorry that was my mistake. Removed!

@chrispader
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

CLABotify added a commit to Expensify/CLA that referenced this pull request Jun 28, 2025
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks again!

@tomekzaw tomekzaw merged commit b5a3cc7 into Expensify:main Jun 28, 2025
4 of 5 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented Jun 28, 2025

🚀 Published to npm in 0.1.290 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants