Capture metrics using react-native-performance
#101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's optional as it's not need by Onyx It will only be used together with `captureMetrics: true` to benchmark Onyx
5 tasks
Contributor
|
This looks good to me, but I'd like @marcaaron to take a look here since I know he's more involved in the performance metrics. |
5 tasks
marcaaron
requested changes
Aug 20, 2021
Contributor
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
This looks good to me, but I spotted a few places where I think it couldn't hurt to add some additional context or clarifying code comments to make it easier to work on for the next person.
Since performance entries are created with `react-native-performance` they no longer contain `endTime`. End time is derived using `call.startTime` + `call.duration`
Contributor
Author
|
Addressed requested changes. Ready for review |
marcaaron
approved these changes
Aug 23, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We're already using
react-native-performancein Expensify/AppUsing it here allows us to visualize Onyx measures in Flipper
Related Issues
Expensify/App#4656 (comment)
Automated Tests
Covered by existing tests
Linked PRs