Add logs to show why Onyx data is changing. Prevent updates when simple values change.#188
Merged
Add logs to show why Onyx data is changing. Prevent updates when simple values change.#188
Conversation
…o update Add test add dequal and debug setState calls remove throw Add setState logging methods remove dequal for now new PR Only include difference not previous/new value Remove dequal stuff Fix test Change param to use so we dont clash with the metrics
90 tasks
grgia
approved these changes
Oct 6, 2022
92 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Related Issues
https://github.com/Expensify/Expensify/issues/230464
Automated Tests
A small automated test was added.
Linked PRs
https://github.com/Expensify/App/compare/marcaaron-debugOnyxSetState