Fix storage/index.native.js to remove Platform.select

[roryabraham]

Details

Fixed a platform-specific file to comply with our guidelines. This was split off into a platform-specific file in this PR, but looking back I'm pretty sure that leaving Platform.select inside index.native.js was a mistake.

Related Issues

n/a

Automated Tests

n/a

Linked PRs

n/a

Testing plan

Create an E/App PR to upgrade the react-native-onyx version and test that the native storage still works (if it doesn't everything will break and we will surely notice). Also tag in an C+ for a thorough review on all platforms.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[roryabraham]

I have read the CLA Document and I hereby sign the CLA

[roryabraham]

recheck

[tgolen]

Did you also test this in a web-only repo like the K2 extension to ensure it still works?

[roryabraham]

Did you also test this in a web-only repo like the K2 extension to ensure it still works?

Nope, I'll do this and post screenshots before merging

[roryabraham]

So I did some research and (in the Comp repo anyways), it turns out that the version of Onyx we are using is from June, 2021, and the latest version of Onyx (deployed to npm) does not work with Comp. So I wasn't able to test this upgrade in isolation, but was able to confirm that the problem was not introduced by this PR.

Furthermore, since this is an index.native.js file I think it's safe to merge and test with an E/App PR. We should create a follow-up issue to make sure that versions of Onyx we deploy to npm are compatible with web-only projects. I was seeing errors like this:

WARNING in ./src/pages/pair/comparison/ComparisonTable.js 267:15-23
export 'withOnyx' (imported as 'withOnyx') was not found in 'react-native-onyx' (possible exports: __esModule)
 @ ./src/pages/pair/ProfilePair.js 26:0-59 174:45-60
 @ ./src/pages/pair/PairPage.js 31:0-40 172:43-54
 @ ./src/pages/LoggedInPages.js 6:0-39 43:15-23
 @ ./src/Comp.js 20:0-50 169:70-83
 @ ./src/index.js 3:0-26 6:50-54

[tgolen]

OK, another repo to check which might be more up-to-date is the k2 extension.

…

On Sat, Oct 15, 2022 at 9:18 AM Rory Abraham ***@***.***> wrote: Merged #197 <#197> into main. — Reply to this email directly, view it on GitHub <#197 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJMAB3LOWCBPKCL4PCO333WDLDNLANCNFSM6AAAAAARCTQEAA> . You are receiving this because your review was requested.Message ID: ***@***.***>

[roryabraham]

I created a follow-up issue here to investigate