Fix idb keyval provider usage in electron environment#307
Merged
mountiny merged 1 commit intoExpensify:mainfrom Aug 21, 2023
Merged
Conversation
Don't initialize the store at bundle load time, but at runtime.
Contributor
|
Related to this Slack thread. |
mountiny
approved these changes
Aug 21, 2023
Contributor
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
thanks for a quick follow up
Contributor
|
I will go ahead and merge this without waiting for Florent as its a quick follow up to previous pr to unblock testing of this perf improvement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Follow up on as there is a crash in the expensify desktop app:
Don't initialise the store at bundle load time, but at runtime. At load time in electron we are on the main thread, which doesn't has access to the browser environment.
Related Issues
Related to #281
Automated Tests
Linked PRs