Use collection key value map instead of recomputing everytime #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountiny
previously approved these changes
Aug 24, 2023
Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com>
mountiny
approved these changes
Aug 24, 2023
Contributor
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Clean simple change, thanks!
tgolen
reviewed
Aug 30, 2023
| */ | ||
| function isCollectionKey(key) { | ||
| return _.contains(_.values(onyxKeys.COLLECTION), key); | ||
| return onyxCollectionKeyMap.has(key); |
Collaborator
There was a problem hiding this comment.
This is causing the jest tests to fail: https://github.com/Expensify/App/actions/runs/6027173662/job/16353221477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
During a performance audit of a large account we noticed, that the
isKeyMatchtime was taking a lot of time. After further investigation we found that this code is problematic:react-native-onyx/lib/Onyx.js
Lines 143 to 145 in 680e3cb
We recompute an array again and again and then use includes on an array to check for a match. Do this thousand of times and it becomes slow. Optimising this code reduced the startup time by ~600ms (on a powerful emulator, effects might be stronger on physical device)
Related Issues
GH_LINK: https://expensify.slack.com/archives/C035J5C9FAP/p1692808883217069
Automated Tests
Linked PRs