Use a map for Onyx collection keys #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Could you please add screenshots showing that the App tests are passing with this change and the app builds? |
cead22
approved these changes
Sep 6, 2023
Contributor
cead22
left a comment
cead22
left a comment
There was a problem hiding this comment.
Could you please add screenshots showing that the App tests are passing with this change and the app builds?
Approving, but waiting for Tim's request to be addressed before we merge
Contributor
Author
|
Here are the passing tests
Here is a screenshot of metro and the app running 
|
Contributor
|
@tgolen I think your concern is addressed. Wanna hit the button or should we HOLD this one for the feature freeze? Probably the latter |
Contributor
|
Going ahead and ship this since we got all the approvals, thanks! |
59 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This change was proposed, merged and reverted due to a failing test and some misscommunication. I've fixed the initial value of the collection map and that also fixes the tests.
Revert PR
This change also provides an improvements to the ReportScreen optimzations Margelo is currently working on.
Related Issues
#329
Automated Tests
Linked PRs