Revert "Merge pull request #289 from pac-guerreiro/feature/remotedev"#337
Merged
mountiny merged 1 commit intoExpensify:mainfrom Sep 12, 2023
ospfranco:osp/revert-devtools
Merged
Revert "Merge pull request #289 from pac-guerreiro/feature/remotedev"#337mountiny merged 1 commit intoExpensify:mainfrom ospfranco:osp/revert-devtools
mountiny merged 1 commit intoExpensify:mainfrom
ospfranco:osp/revert-devtools
Conversation
melvin-bot
bot
requested review from
dangrous
and removed request for
a team
mountiny
approved these changes
Sep 12, 2023
Contributor
mountiny
left a comment
mountiny
left a comment
There was a problem hiding this comment.
Confirmed the changes match up, going to merge to unblcok Oscar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 35ef09a, reversing changes made to d03c2a3.
Conflicts:
lib/DevTools.js
Details
The DevTools PR causes a runtime error when trying to run the app either via Jest tests or with Metro attached
For now @mountiny and I think it is better to revert it as it is blocking other improvements
Related Issues
GH_LINK
Automated Tests
Linked PRs