Add instructions and best practices to the README for dependent props#342
Merged
hayata-suenaga merged 2 commits intomainfrom Sep 18, 2023
Merged
Add instructions and best practices to the README for dependent props#342hayata-suenaga merged 2 commits intomainfrom
hayata-suenaga merged 2 commits intomainfrom
Conversation
mountiny
previously approved these changes
Sep 15, 2023
Contributor
|
Looks good to me, thank you! |
hayata-suenaga
previously approved these changes
Sep 15, 2023
Member
|
What I used was two export default withOnyx({
report: {
key: ({reportID) => `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
}})
withOnyx({
policy: {
key: ({report}) => `${ONYXKEYS.COLLECTION.POLICY}${report.policyID}`,
},
})(App);Is this different from single |
Co-authored-by: Ana Margarida Silva <ams-amargarida@hotmail.com>
51956f7
Collaborator
Author
|
@parasharrajat It functionally results in the same end result, but with two |
Member
|
Glad to know. Thanks for the explanation. |
Collaborator
Author
|
@mountiny @hayata-suenaga do one of you want to go ahead and merge this? |
hayata-suenaga
approved these changes
Sep 18, 2023
59 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from this slack convo: https://expensify.slack.com/archives/C01GTK53T8Q/p1694710295343199
cc @mountiny @marcaaron @allroundexperts