Skip to content

Revert "Allow infinite dependent keys when using withOnyx"#357

Merged
mountiny merged 1 commit intomainfrom
revert-355-tgolen-dependent-keys
Sep 21, 2023
Merged

Revert "Allow infinite dependent keys when using withOnyx"#357
mountiny merged 1 commit intomainfrom
revert-355-tgolen-dependent-keys

Conversation

@tgolen
Copy link
Collaborator

@tgolen tgolen commented Sep 21, 2023

Reverts #355

Discussion in https://expensify.slack.com/archives/C01GTK53T8Q/p1695278625487999

This PR is causing extreme performance problems when switching chats.

@tgolen tgolen self-assigned this Sep 21, 2023
@tgolen tgolen marked this pull request as ready for review September 21, 2023 08:02
@tgolen tgolen requested a review from a team as a code owner September 21, 2023 08:02
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team September 21, 2023 08:03
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit 4443911 into main Sep 21, 2023
@tgolen tgolen deleted the revert-355-tgolen-dependent-keys branch September 21, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants