Use "set" in IDBKeyVal.mergeItem instead of duplicate merge logic #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
cristipaval
and removed request for
a team
This was referenced Sep 21, 2023
tgolen
approved these changes
Sep 22, 2023
marcaaron
approved these changes
Sep 22, 2023
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcaaron @tgolen
Details
Since in
Onyx.mergewe already read the existing value and merge it with the changes, we don't need to do that inIDBKeyVal.mergeItem()anymore. Therefore, we will simply useIDBKeyVal.setItem()directly.Related Issues
#333 (comment)
Automated Tests
Linked PRs