Use fast path when we ask for just one key in Connect() #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountiny
requested changes
Sep 25, 2023
melvin-bot
bot
requested review from
youssef-lr
and removed request for
a team
marcaaron
reviewed
Oct 19, 2023
| && !(mapping.key.endsWith('_')) | ||
| && cache.storageKeys.has(mapping.key) | ||
| ) { | ||
| return [mapping.key]; |
Contributor
There was a problem hiding this comment.
NAB, but now that we do this - some of the comments below are a little misleading. Since this is not a key that we found (we just assumed it exists).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found out that getAllKeys can be extremely slow as it's used very frequently and it just copies keys from cache to just created array. Because on heavy account number of keys can easily reach 50k that takes quite some time.
In most of the cases we only ask for one keys so to speed it up we just check if it's in the set of keys if it is then we return array with just this item.
Details
Related Issues
GH_LINK
Automated Tests
Linked PRs