Use map for keeping pending promises #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mountiny
requested changes
Sep 25, 2023
| * @type {Record<string, Promise>} | ||
| */ | ||
| this.pendingPromises = {}; | ||
| this.pendingPromises = new Map(); |
Contributor
There was a problem hiding this comment.
Could you update the docs above and leave a comment why we chose to use Map?
Contributor
There was a problem hiding this comment.
What do you mean with the docs though? Docs are only generated from onyx.js, and not from other internal implementation files such as this one
Contributor
There was a problem hiding this comment.
@type {Record<string, Promise>} I meant this
melvin-bot
bot
requested review from
youssef-lr
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map is faster than object when we have a lot of items. Using map in this place seems to improve chat switching performance.
Details
Related Issues
GH_LINK
Automated Tests
Linked PRs