Propagate merge events across tabs #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
luacmartins
and removed request for
a team
luacmartins
approved these changes
Sep 27, 2023
Contributor
luacmartins
left a comment
luacmartins
left a comment
There was a problem hiding this comment.
LGTM and I think this is what we want
Contributor
|
@ospfranco wanna work on the App version bump? |
Contributor
Author
|
Will do |
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There is currently a bug with data propagation across tabs. After some debugging I found out that
mergeevents are not propagated across tabs. This fixes the issue, but not sure if it is the correct solution, since it will propagate all merge events across tabs, which might increase the loads on the pages. A review is required.Related Issues
Expensify/App#26190
Automated Tests
Linked PRs