Skip to content

Reapply "Remove macro/micro tasks during subscriber update"#760

Open
VickyStash wants to merge 3 commits intoExpensify:mainfrom
callstack-internal:VickyStash/refactor/82871-remove-micro-macro-tasks
Open

Reapply "Remove macro/micro tasks during subscriber update"#760
VickyStash wants to merge 3 commits intoExpensify:mainfrom
callstack-internal:VickyStash/refactor/82871-remove-micro-macro-tasks

Conversation

@VickyStash
Copy link
Contributor

@VickyStash VickyStash commented Mar 23, 2026 •
edited
Loading

Details

Second try for this PR #724
It was reverted here: #758

Check the issue description for details.

App PR: Expensify/App#85919

Related Issues

$ Expensify/App#82871

Automated Tests

Should be covered by existing tests + new tests/unit/collectionHydrationTest.ts

Manual Tests

The E/App should work the same way as before. Let's verify basic test steps:

  1. Login with a account.
  2. Navigate to a chat, send a message. React to that message.
  3. Reply to that message in a new thread.
  4. Create a new task, navigate to its details and mark it as completed.
  5. Create a new expense (scan expense) to someone else, navigate to its details.
  6. Go to Reports tab, Expenses, make sure you can find your expense and see its details.
  7. Create a new workspace, make sure the rooms were created.

Author Checklist

  • I linked the correct issue in the ### Related Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
android.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios_web.mov
MacOS: Chrome / Safari
web.mp4

@VickyStash
Revert "Merge pull request Expensify#758 from Expensify/revert-724-Vi…
a1638ea 
…ckyStash/poc/get-rid-of-macro-micro-tasks"

This reverts commit 381c36a, reversing
changes made to 1ab73fe.
@VickyStash VickyStash marked this pull request as ready for review March 23, 2026 16:06
@VickyStash VickyStash requested a review from a team as a code owner March 23, 2026 16:06
@melvin-bot melvin-bot bot requested review from MarioExpensify and removed request for a team March 23, 2026 16:06
@VickyStash VickyStash mentioned this pull request Mar 23, 2026
Open
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 23, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1638ea180

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

lib/OnyxUtils.ts Outdated
Comment on lines 852 to 853
if (lastConnectionCallbackData.has(mapping.subscriptionID) && shallowEqual(lastValue, value)) {
return;
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Deduplicate connect hydration callbacks by key

sendDataToConnection() now suppresses callbacks using shallowEqual(lastValue, value) without considering matchedKey. For collection subscriptions that do not use waitForCollectionCallback, this can drop legitimate callbacks for different collection members when their payloads are shallow-equal (for example during connect() hydration racing with an immediate set(), where lastConnectionCallbackData is already populated). In that case some keys are never delivered to the subscriber, leaving the caller with an incomplete collection view.

Useful? React with 👍 / 👎.

Copy link
Contributor

@MarioExpensify MarioExpensify Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VickyStash did you take a look at this comment?

Copy link
Contributor Author

@VickyStash VickyStash Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a closer look in a bit!

Copy link
Contributor Author

@VickyStash VickyStash Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid, addressed in a19cc41

@VickyStash
Copy link
Contributor Author

VickyStash commented Mar 24, 2026

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 24, 2026
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a19cc41cd0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

lib/OnyxUtils.ts
}

return scheduleSubscriberUpdate(key, value, (subscriber) => hasChanged || subscriber?.initWithStoredValues === false).then(() => undefined);
keyChanged(key, value, (subscriber) => hasChanged || subscriber?.initWithStoredValues === false);
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Prevent subscriber exceptions from aborting persistence

broadcastUpdate() now calls keyChanged() synchronously, and keyChanged() executes user-provided connect callbacks without a guard. If any subscriber callback throws, that exception bubbles out immediately and short-circuits callers like setWithRetry()/applyMerge() before Storage.setItem()/mergeItem() run, leaving cache updates visible but not persisted to storage. This regression is introduced by removing the deferred update path, so callback failures should be isolated (e.g., deferred or wrapped) to avoid data loss on write operations.

Useful? React with 👍 / 👎.

Copy link
Contributor Author

@VickyStash VickyStash Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled in f63331e

@VickyStash
Wrap keyChanged/keysChanged with function-level try/catch to prevent…
f63331e 
… subscriber errors from blocking storage updates
@Krishna2323
Copy link

Krishna2323 commented Mar 24, 2026

I didn't get tagged by melv on this PR. Will complete the review and testing today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@MarioExpensify MarioExpensify Awaiting requested review from MarioExpensify

At least 1 approving review is required to merge this pull request.

Assignees

@VickyStash VickyStash

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VickyStash @Krishna2323 @MarioExpensify