Implement basic map view #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 11, 2023 10:24
thienlnam
requested changes
Aug 11, 2023
Contributor
thienlnam
left a comment
thienlnam
left a comment
There was a problem hiding this comment.
Looks good, can’t speak much to the Mapbox stuff but left some comments regarding keeping conventions same as App styling
thienlnam
approved these changes
Aug 11, 2023
Comment on lines
+36
to
+47
| useImperativeHandle( | ||
| ref, | ||
| () => ({ | ||
| flyTo: (location: [number, number], animationDuration?: number) => cameraRef.current?.flyTo(location, animationDuration), | ||
| }), | ||
| [], | ||
| ); | ||
|
|
||
| // Initialize Mapbox on first mount | ||
| useEffect(() => { | ||
| Mapbox.setAccessToken(accessToken); | ||
| }, []); |
There was a problem hiding this comment.
This code caused Expensify/App#25732. Map box API doesn't seem to support flyTo well enough on native platforms.
Contributor
Author
There was a problem hiding this comment.
it's rather the issue with the libraries themself than a regression but yea we should have tested this thoroughly
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR creates a cross-platform
MapViewcomponent.Related Issues
Expensify/App#22703
Manual Tests
The component is tested in this App PR. I can open a follow up PR to include automated tests on the library itself after high priority issues are done. However, I don't have a good idea on how to test visual elements on Map.
Linked PRs
Expensify/App#24306