Copy changes to right branch for deployment.#59
Closed
johnmlee101 wants to merge 2 commits intoExpensify-0.71.2-alpha.4from
Closed
Copy changes to right branch for deployment.#59johnmlee101 wants to merge 2 commits intoExpensify-0.71.2-alpha.4from
johnmlee101 wants to merge 2 commits intoExpensify-0.71.2-alpha.4from
Conversation
Author
|
@roryabraham this is fine, and I will deploy to the new branch Expensify-0.71.2-alpha.4 once this is done, correct? |
Author
|
Bump! |
|
@johnmlee101 Sorry, have been OOO. I think we need to be targeting https://github.com/Expensify/react-native/tree/ExpensifyRC1-0.72.0-alpha.0 |
|
More importantly though, we shouldn't merge any changes that we don't view as having a high likelihood of being merged upstream. Judging by the latest comment in the upstream PR, there are some changes needed. This fix appears unlikely to be merged as-is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying over from #45
Upstream PR Link
facebook#36428
Summary
For Expensify/App#15310
Changelog
[CATEGORY] [TYPE] - Message
Test Plan