Skip to content

Integrations#37

Merged
JoE11-y merged 2 commits intomainfrom
integrations
Oct 21, 2025
Merged

Integrations#37
JoE11-y merged 2 commits intomainfrom
integrations

Conversation

@JoE11-y
Copy link
Copy Markdown
Contributor

@JoE11-y JoE11-y commented Oct 21, 2025

Summary by CodeRabbit

  • New Features
    • Trade API responses now include adChainId and orderChainId fields, providing explicit blockchain network identifiers for advertisements and orders in trade data.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
proof-bridge Building Building Preview Comment Oct 21, 2025 10:21am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Oct 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Two new fields—adChainId and orderChainId—are added to the TradeResponseDto and computed in the trade service's getById and list methods. The fields are derived from token chain identifiers and included in both top-level and nested route representations in the API response.

Changes

Cohort / File(s) Summary
Chain ID exposure in Trade DTO and service
apps/backend-relayer/src/modules/trades/dto/trade.dto.ts, apps/backend-relayer/src/modules/trades/trade.service.ts
Added adChainId and orderChainId properties to TradeResponseDto with ApiProperty metadata. Updated getById and list methods in trade.service.ts to compute these fields from respective token chains and include them at top level and in nested route representations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Integrations #14: Adds chainId fields across trade/ads DTOs and viem service/types—shares the goal of surfacing blockchain chain ID values in trade data structures.
  • Frontend in app #27: Introduces adChainId in frontend trade request/response types (orderParams/ICreateTradeResponse and ITrade)—directly aligns with the backend data contract exposed by this PR.
  • feat: add response dtos #10: Previously introduced/renamed TradeResponseDto and adjusted chain/ID handling—this PR builds upon that foundation by extending the DTO with new chain ID fields.

Poem

🐰 Through chains we hop, from ad to order trades,
Chain IDs now bright, no more in shades,
Routes enriched, each transaction clear,
The rabbit's DTO brings data near! 🌟

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch integrations

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0ee3c5 and 0890c5c.

📒 Files selected for processing (2)
  • apps/backend-relayer/src/modules/trades/dto/trade.dto.ts (1 hunks)
  • apps/backend-relayer/src/modules/trades/trade.service.ts (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JoE11-y JoE11-y merged commit 3bec752 into main Oct 21, 2025
1 of 3 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant